From: Michal Hocko <mhocko@kernel.org>
To: Alastair D'Silva <alastair@d-silva.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>,
Mike Rapoport <rppt@linux.ibm.com>,
Dan Williams <dan.j.williams@intel.com>,
Wei Yang <richardw.yang@linux.intel.com>,
David Hildenbrand <david@redhat.com>, Qian Cai <cai@lca.pw>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: don't hide potentially null memmap pointer in sparse_remove_section
Date: Tue, 27 Aug 2019 09:22:42 +0200 [thread overview]
Message-ID: <20190827072242.GT7538@dhcp22.suse.cz> (raw)
In-Reply-To: <befab2a0a9f160f8af8c1a412068060636a7a64c.camel@d-silva.org>
On Tue 27-08-19 17:00:16, Alastair D'Silva wrote:
[...]
> The NULL check was added in commit:
> 95a4774d055c ("memory-hotplug: update mce_bad_pages when removing the
> memory")
> where memmap was originally inited to NULL, and only conditionally
> given a value.
>
> With this in mind, since that situation is no longer true, I think we
> could instead drop the NULL check.
This would be much more preferable to the original patch.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2019-08-27 7:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 5:36 [PATCH 0/2] mm: Minor cleanup Alastair D'Silva
2019-08-27 5:36 ` [PATCH 1/2] mm: Don't manually decrement num_poisoned_pages Alastair D'Silva
2019-08-27 6:25 ` Michal Hocko
2019-08-27 7:07 ` David Hildenbrand
2019-08-27 7:31 ` Mike Rapoport
2019-08-28 0:39 ` Wei Yang
2019-08-28 7:31 ` Oscar Salvador
2019-08-27 5:36 ` [PATCH 2/2] mm: don't hide potentially null memmap pointer in sparse_remove_section Alastair D'Silva
2019-08-27 6:24 ` Michal Hocko
2019-08-27 7:00 ` Alastair D'Silva
2019-08-27 7:08 ` David Hildenbrand
2019-08-27 7:22 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827072242.GT7538@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alastair@d-silva.org \
--cc=cai@lca.pw \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=richardw.yang@linux.intel.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox