From: Andrew Morton <akpm@linux-foundation.org>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Henry Burns <henrywolfeburns@gmail.com>
Subject: Re: [mmotm:master 14/264] mm/zsmalloc.c:2415:27: error: 'struct zs_pool' has no member named 'migration_wait'
Date: Mon, 26 Aug 2019 16:14:34 -0700 [thread overview]
Message-ID: <20190826161434.1ed94d3e4c93833f54dddb01@linux-foundation.org> (raw)
In-Reply-To: <201908251039.5oSbEEUT%lkp@intel.com>
On Sun, 25 Aug 2019 10:53:43 +0800 kbuild test robot <lkp@intel.com> wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: f50a6baf25034cdc74a3c2a919c455076f776944
> commit: 5e656681183d9045de7815921012f5731c16eae3 [14/264] mm/zsmalloc.c: fix race condition in zs_destroy_pool
> config: i386-randconfig-c003-201934 (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
> reproduce:
> git checkout 5e656681183d9045de7815921012f5731c16eae3
> # save the attached .config to linux build tree
> make ARCH=i386
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/mmzone.h:10:0,
> from include/linux/gfp.h:6,
> from include/linux/umh.h:4,
> from include/linux/kmod.h:9,
> from include/linux/module.h:13,
> from mm/zsmalloc.c:33:
> mm/zsmalloc.c: In function 'zs_create_pool':
> >> mm/zsmalloc.c:2415:27: error: 'struct zs_pool' has no member named 'migration_wait'
> init_waitqueue_head(&pool->migration_wait);
> ^
> include/linux/wait.h:67:26: note: in definition of macro 'init_waitqueue_head'
> __init_waitqueue_head((wq_head), #wq_head, &__key); \
Thanks.
--- a/mm/zsmalloc.c~mm-zsmallocc-fix-build-when-config_compaction=n
+++ a/mm/zsmalloc.c
@@ -2412,7 +2412,9 @@ struct zs_pool *zs_create_pool(const cha
if (!pool->name)
goto err;
+#ifdef CONFIG_COMPACTION
init_waitqueue_head(&pool->migration_wait);
+#endif
if (create_cache(pool))
goto err;
_
prev parent reply other threads:[~2019-08-26 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 2:53 kbuild test robot
2019-08-26 23:14 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826161434.1ed94d3e4c93833f54dddb01@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=henrywolfeburns@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox