linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Khalid Aziz <khalid.aziz@oracle.com>
Cc: akpm@linux-foundation.org, vbabka@suse.cz,
	mgorman@techsingularity.net, dan.j.williams@intel.com,
	osalvador@suse.de, richard.weiyang@gmail.com, hannes@cmpxchg.org,
	arunks@codeaurora.org, rppt@linux.vnet.ibm.com, jgg@ziepe.ca,
	amir73il@gmail.com, alexander.h.duyck@linux.intel.com,
	linux-mm@kvack.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] Add predictive memory reclamation and compaction
Date: Tue, 13 Aug 2019 16:05:53 +0200	[thread overview]
Message-ID: <20190813140553.GK17933@dhcp22.suse.cz> (raw)
In-Reply-To: <20190813014012.30232-1-khalid.aziz@oracle.com>

On Mon 12-08-19 19:40:10, Khalid Aziz wrote:
[...]
> Patch 1 adds code to maintain a sliding lookback window of (time, number
> of free pages) points which can be updated continuously and adds code to
> compute best fit line across these points. It also adds code to use the
> best fit lines to determine if kernel must start reclamation or
> compaction.
> 
> Patch 2 adds code to collect data points on free pages of various orders
> at different points in time, uses code in patch 1 to update sliding
> lookback window with these points and kicks off reclamation or
> compaction based upon the results it gets.

An important piece of information missing in your description is why
do we need to keep that logic in the kernel. In other words, we have
the background reclaim that acts on a wmark range and those are tunable
from the userspace. The primary point of this background reclaim is to
keep balance and prevent from direct reclaim. Why cannot you implement
this or any other dynamic trend watching watchdog and tune watermarks
accordingly? Something similar applies to kcompactd although we might be
lacking a good interface.
-- 
Michal Hocko
SUSE Labs


  parent reply	other threads:[~2019-08-13 14:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  1:40 Khalid Aziz
2019-08-13  1:40 ` [RFC PATCH 1/2] mm: Add trend based prediction algorithm for memory usage Khalid Aziz
2019-08-13  1:40 ` [RFC PATCH 2/2] mm/vmscan: Add fragmentation and page starvation prediction to kswapd Khalid Aziz
2019-08-13 14:05 ` Michal Hocko [this message]
2019-08-13 15:20   ` [RFC PATCH 0/2] Add predictive memory reclamation and compaction Khalid Aziz
2019-08-14  8:58     ` Michal Hocko
2019-08-15 16:27       ` Khalid Aziz
2019-08-15 17:02         ` Michal Hocko
2019-08-15 20:51           ` Khalid Aziz
2019-08-21 14:06             ` Michal Hocko
2019-08-26 20:44               ` Bharath Vedartham
2019-08-27  6:16                 ` Michal Hocko
2019-08-28 13:09                   ` Bharath Vedartham
2019-08-28 13:15                     ` Michal Hocko
2019-08-30 21:35                   ` Khalid Aziz
2019-09-02  8:02                     ` Michal Hocko
2019-09-03 19:45                       ` Khalid Aziz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190813140553.GK17933@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=amir73il@gmail.com \
    --cc=arunks@codeaurora.org \
    --cc=dan.j.williams@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=jgg@ziepe.ca \
    --cc=khalid.aziz@oracle.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=osalvador@suse.de \
    --cc=richard.weiyang@gmail.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox