From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A8CC32751 for ; Wed, 7 Aug 2019 17:18:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A9BEE22305 for ; Wed, 7 Aug 2019 17:18:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="ig7/cLvz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9BEE22305 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 51F176B0008; Wed, 7 Aug 2019 13:18:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D06D6B000C; Wed, 7 Aug 2019 13:18:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 398F06B000D; Wed, 7 Aug 2019 13:18:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by kanga.kvack.org (Postfix) with ESMTP id DCBB56B0008 for ; Wed, 7 Aug 2019 13:18:04 -0400 (EDT) Received: by mail-ed1-f71.google.com with SMTP id f3so56505635edx.10 for ; Wed, 07 Aug 2019 10:18:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:thread-topic :thread-index:date:message-id:references:in-reply-to:accept-language :content-language:content-id:content-transfer-encoding:mime-version; bh=D4huSkCeVNugOTHQQcM6pySCS6vXgZT5Dzc2lhNeyww=; b=qbaZZdM6/3EvL5x85+TBEjc3gEtkAKrQZ2WFiPblYJzNtECjrQ+RuaZg82FSEk8P0Z HSbnJFdU7Ip8gTVnJsqR1w/NAdV+OncAQ9izQgSF+oqNHIw62i+1yKk9l7BiiTYMK6Sa JIO0loWbMsqmUhL93eb8MbH1IrpQFUHYXRta2QEdt14whH2pdQLfVqFdRlApa4JLxrhW o5b71PElwXjgx5cwQ+zsV8jtTaAhJXexxDXHV8CBT90UWH+x0qZw2dyFlkYcq2vMb/5I bMindGW960OLtgKwoJbXgjEMsoV6yFpStaivf0puPZgQTMRmzU3oWg5tOHzqBfsPPHbs HPyQ== X-Gm-Message-State: APjAAAX1Pd1jJDn5rWvYA1A+Y4wT74XfMxuWxYjsoUIJNu5m4m/GK5+9 ml8rXBzWcVNWAplX/BnN7nNis7GWt5WaAPj4zMC3EXUkERXuGqq0QFjNpQUY8YEiyA5vYuCSFrd kQS9Iq81Bxo4DVKEUl12+cXtFu7lpH4B7cjYtcUwUX7SIAi6LdGHSIW5cG06Y4O1anA== X-Received: by 2002:a50:f5f5:: with SMTP id x50mr10834745edm.89.1565198284391; Wed, 07 Aug 2019 10:18:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqzOtsFu5EKSJs4vbSCaUs2qUE1L54MRNGMHtYrb3EGKasGFPBCBwJuYSOplkdrc4r8r/xGr X-Received: by 2002:a50:f5f5:: with SMTP id x50mr10834686edm.89.1565198283747; Wed, 07 Aug 2019 10:18:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1565198283; cv=pass; d=google.com; s=arc-20160816; b=c+gXB15O0EUqQC+2MY8aALMPRBoE0aU7OZQOv1rtLvCc0Vax14lD1aDsoAoiFjNFp4 S0Sa4evnCtTbLqB79zvA2sulEXtLObjVDPj1uaJ/jFTKxR+Vj9X5TjXXA1C9XvK9x/c1 3gbD/8poKXX0BXdwOY9b4DkoX/9qbVJtUl+4HHw851jaksSn9Ea/4Mh5adwvebSTiCsN SHUunoqYhMndrgt8TNrj3H54y3LA3b35jcey7GOFVUTnNXz57R2YguNc2IEoHUz9EJF8 sk2bDZUWztRmH64eptg6FQ73zhHOeGkm1T1Mx81adLeldHBxBXNKaiEeyyZ10/PwAdo8 dQzA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-id:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature; bh=D4huSkCeVNugOTHQQcM6pySCS6vXgZT5Dzc2lhNeyww=; b=yurAK58ddKQCAyE5KXAKZbr5u36r+d4mYB4efJTKqWqVHxF8TOA6mfqPt5BfYaO9N1 g9Y7n+KT6u61NY1rlUp3UnD5Tc1/8oPk/vmQW6WNtkYjSyaD/B2nJnqx6thVe5QPJWxS /fac9Cl/MARv8EcY3udnfXd1GEcyp6bCGOWEvkts8eoJwgQ2vLqiErTgOPijC7EV6YiA kNCty6G53lpSKXQ21VpywE83xRYwZrRoLxJgUHMmyVssYru1Qc9llpHHfFYWhCablrQI DyuCVwwfaYizMGZ/BxAFQ904H/3l1vTEbUhxiG8bx3Fx64Borg6f6zAxgh7TDacMTJil IJ7g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector2 header.b="ig7/cLvz"; arc=pass (i=1 spf=pass spfdomain=mellanox.com dkim=pass dkdomain=mellanox.com dmarc=pass fromdomain=mellanox.com); spf=pass (google.com: domain of jgg@mellanox.com designates 40.107.1.61 as permitted sender) smtp.mailfrom=jgg@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10061.outbound.protection.outlook.com. [40.107.1.61]) by mx.google.com with ESMTPS id p15si29250395eju.348.2019.08.07.10.18.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Aug 2019 10:18:03 -0700 (PDT) Received-SPF: pass (google.com: domain of jgg@mellanox.com designates 40.107.1.61 as permitted sender) client-ip=40.107.1.61; Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector2 header.b="ig7/cLvz"; arc=pass (i=1 spf=pass spfdomain=mellanox.com dkim=pass dkdomain=mellanox.com dmarc=pass fromdomain=mellanox.com); spf=pass (google.com: domain of jgg@mellanox.com designates 40.107.1.61 as permitted sender) smtp.mailfrom=jgg@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M38IFZTtLXhblLeUKSTOOyY+BzP5VWo2NxFpFzFwsSqL+5D1WSw3A42cJnXH5TiCRayVqKFZ/Bfc22qbGvGxoRHxL/6ToaI+ZJeNohrGahSVStM0Xm7+8MhermUY7N3a9g9IJwASLTMEEpfjx2cUrkuGPiqkoH1n8ubVfqjURQ3lvfOMI8jTiZb4ftvJ4zSCiXGJolt2MkOQmUvueKUHQZn56LyqVsIFD397xBtsYISJaPQhroaJcCgwGGP78QXI/RnxF43yCljkSpEy9cvyT4qWPMBWQyCIsLTa4c9RSy6gpyQGFhVmWxTyNoQXk+VJgCLqksZftFbNthMbkGdOvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D4huSkCeVNugOTHQQcM6pySCS6vXgZT5Dzc2lhNeyww=; b=l2mAxgVVWXYxtwncWCfB/L6SZSZ7k8JfjYlANp+YoptrbzgWe7lXBk3vOq2bo+2KV0UA1j+JEqdnP8DF6qcI3bfteRGLxIbA2P6aH6x8d9IlK7MtMyoLNcCAvih/CXKs2qLpP9H/sVa1Ek/3h5ML6Ga+hYPYG9JQMKI1CcRhDwWh8tLamShUlyMQyhNBt2cXTg2hWjB5mszT8w3g5jSwXGe6XY76nbwe7tIuUYrTGBEwyf+cbF6E80kVdvYgC+oYuJgQl2+OZhnXi/QYulSd5+btBX1tTn/C4Dprf8m9w5rL0wz2VtatfuLBVwh6OhotsqLhcH5WHT8I5Puv2qYWYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D4huSkCeVNugOTHQQcM6pySCS6vXgZT5Dzc2lhNeyww=; b=ig7/cLvzVZOMNO+zztVocw6DLqmOk29OTrf6rZ2X7ZKua0vsUnomtAQRo1svdHUv8s6uISaDHFY6LgbVHR9qvRnEBfoTMG6ejM7vHHuDzwlgxXs11O7tahRu6YxbjLTCLxpo+owGhyodk0CKMpYfvCrdMxraPNNXMyub0L++Bg0= Received: from VI1PR05MB4141.eurprd05.prod.outlook.com (10.171.182.144) by VI1PR05MB4671.eurprd05.prod.outlook.com (20.176.3.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.20; Wed, 7 Aug 2019 17:18:01 +0000 Received: from VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::5c6f:6120:45cd:2880]) by VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::5c6f:6120:45cd:2880%4]) with mapi id 15.20.2136.018; Wed, 7 Aug 2019 17:18:01 +0000 From: Jason Gunthorpe To: Christoph Hellwig CC: =?iso-8859-1?Q?J=E9r=F4me_Glisse?= , Ben Skeggs , Felix Kuehling , Ralph Campbell , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 09/15] mm: don't abuse pte_index() in hmm_vma_handle_pmd Thread-Topic: [PATCH 09/15] mm: don't abuse pte_index() in hmm_vma_handle_pmd Thread-Index: AQHVTHDjVWJoFh6NnUauF/brrPZnVqbv7ziA Date: Wed, 7 Aug 2019 17:18:01 +0000 Message-ID: <20190807171755.GI1571@mellanox.com> References: <20190806160554.14046-1-hch@lst.de> <20190806160554.14046-10-hch@lst.de> In-Reply-To: <20190806160554.14046-10-hch@lst.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: YTOPR0101CA0044.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:14::21) To VI1PR05MB4141.eurprd05.prod.outlook.com (2603:10a6:803:4d::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [156.34.55.100] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8c56f4fe-05c7-40ef-c6c0-08d71b5b333e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB4671; x-ms-traffictypediagnostic: VI1PR05MB4671: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 01221E3973 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(4636009)(376002)(346002)(39860400002)(366004)(396003)(136003)(199004)(189003)(6246003)(53936002)(33656002)(6436002)(6486002)(6512007)(6116002)(68736007)(54906003)(3846002)(2906002)(66066001)(316002)(36756003)(71190400001)(476003)(2616005)(11346002)(186003)(446003)(14444005)(26005)(102836004)(99286004)(66476007)(64756008)(7416002)(66556008)(71200400001)(256004)(305945005)(25786009)(5660300002)(6506007)(386003)(66446008)(8936002)(86362001)(52116002)(6916009)(14454004)(229853002)(8676002)(1076003)(4326008)(81166006)(478600001)(66946007)(4744005)(81156014)(7736002)(486006)(76176011)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB4671;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Y5w2T4TwDEqVW/A/CS5dCgeAwrt8PXGrtm3uRFpMUQxqZmB+oFSvM857UGs06YXyJV1Opb+rNLObiLz2oz48V4ILUx67rdmHAh7jF9WQQzStmE67vdRyKeC91312yvdFPK7QrHPS85XneYw91kz3ArXf1ktjAmP89EfXUOBwPwZqXtC7Fdjq0yEOLfPNTWFGHNLdu75ZvrIXN7EBCXOGkhQu2YfcH8n2FwrK+CPdGvCNhQks2gVxXRrAS3cmhtCGwx08yK1pH2H10rwUWRzDCMPrm/Poynzo+p2AZ2rCAvNZNJ2NG+dOEr4V8O+SHkCh4/PhIg8HO6L5wlXFF9hi2FgYbN3CmNN3WBTa441cdg9OlCfmlA3XrqA+o/NyPwFbtLjRnPXzSBHRt8a9bBek4Qa+hk0mLXMyGBqeA2rLTOk= Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c56f4fe-05c7-40ef-c6c0-08d71b5b333e X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2019 17:18:01.4239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jgg@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4671 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 06, 2019 at 07:05:47PM +0300, Christoph Hellwig wrote: > pte_index is an internal arch helper in various architectures, > without consistent semantics. Open code that calculation of a PMD > index based on the virtual address instead. >=20 > Signed-off-by: Christoph Hellwig > --- > mm/hmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) There sure are a lot of different ways to express this, but this one looks OK to me, at least the switch from the PTRS_PER_PTE expression in the x86 imlpementation to PMD_MASK looks equivalent =20 Reviewed-by: Jason Gunthorpe Jason