From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ACDCC31E40 for ; Tue, 6 Aug 2019 11:57:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CF60820B1F for ; Tue, 6 Aug 2019 11:57:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF60820B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 53E0F6B0003; Tue, 6 Aug 2019 07:57:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EF406B0006; Tue, 6 Aug 2019 07:57:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4050F6B0008; Tue, 6 Aug 2019 07:57:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by kanga.kvack.org (Postfix) with ESMTP id E4DF56B0003 for ; Tue, 6 Aug 2019 07:57:07 -0400 (EDT) Received: by mail-ed1-f72.google.com with SMTP id b33so53688664edc.17 for ; Tue, 06 Aug 2019 04:57:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:references:mime-version:content-disposition :in-reply-to:user-agent; bh=GRpeJyT3ltpVrhNYWQh1yp5wYV2JE6Z63T2HfbENV84=; b=PtGcwz5rUxUxkgguH5L1wB+Nkt88Ff0OLglN2yBHSBS2988asZjnnpRoDsoT/sMqf9 b1p+AjArtH9llLlb0MuRRnjc1v3XOfQRmWr2KXQaaag6keuNwP5o+iIgymaE1OL3v/M8 TkY454IBqmyNw11fzxiHID4yzdXdCHi4keBa7fU5cXsllr7Yai/6Z87X42gFOJEaq2A7 R9eU7uc2Weuxdf6G+MqBApTDwCGgOAl0G+kuncz6SSUgeFt87Ka91HlbD/rmaAx4tMPZ EDMOokcSMt1CKSartqP0T34p3IJQUbjxetm4h172JLvIYhWwO5ytJxJSpnKGpRBMFkJ4 mIZQ== X-Original-Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Gm-Message-State: APjAAAV5S8LueL3w2QsIRF3BBqXQjxeS3HoagBqinvRfTlebbn+ZwZ4I W26llIKmV0PfNb/DmxW7imdNDDrHx1DYtfieDemFDMFHTYIlIE0BpxVDSSHeojVa868eHllotbv kbLBpt6TGEIknjSJtYqxS3LGTByjg8ReFLcNudS/DJHoX4YZCpcoNa89oAG3Ih/o= X-Received: by 2002:a17:906:7c8d:: with SMTP id w13mr2674339ejo.264.1565092627455; Tue, 06 Aug 2019 04:57:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDHE/px4Mm6zbwvIc0ChO6qU8qrhGLCsuQjLupQ/5XVJvhYOHYEkk3YYxZlR8T0/e27quU X-Received: by 2002:a17:906:7c8d:: with SMTP id w13mr2674295ejo.264.1565092626666; Tue, 06 Aug 2019 04:57:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565092626; cv=none; d=google.com; s=arc-20160816; b=Hv1AdzWTUrPnKymVSM/l94WOiwnttOy9magzMRLOE6OzyfsMxHDdswqo95VxTIX+Jp B1kOG8++iz2Uv/MZ5ZpzH2Xf97OkhhEjbBJGBJ0zuc9bGyCmbgGAZe5/I7ETgD0lhnzJ KIdxbMf6Qpb3lcRKOelRz6mgfV0DO2GOVCABVUOqK+XEHeOTEcwj62mlR/qhtrHK9Era R9yeyU4oSJvmJPXrB+IuDxAsHiId45kPOx946yaBze3E+ByuyC9r0ARsxtRNGppui3WD aEx4FXJVZdJC4fviTI8O8s/7YKA0yTelY9+b0ljJvcBEOnyowLe+92MIDK+s1QnsUCgF aQ1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date; bh=GRpeJyT3ltpVrhNYWQh1yp5wYV2JE6Z63T2HfbENV84=; b=iRFwh/8c4XK0t+loIEkGPgswCPXmE5tJIBh+BLIOhy2/2aR1q8yKV9X0dkcMR5GJrk 7OQ5YZwX8oRL1jDvW/ySmxP8hlMtaKIauIDyB+GZGg9MDzAoETrwEgP8ofOpQiWnHAER H6ygeW814qoNShcSBK65NFqhQQtlGwbFzqvZvJTQ5H0qfH0yx0vIPafqRdX9NkRjRzUg OMokSWz0yNk6UctZkbnFr9Y+jFnjKdyTD1nUs1JRsTjcmY5ddLKh6iTaENxfIdb3rhqO e33viJNtnrP/Swpvu9dJ/GV2lprGvXgvZOfgkL0aE8aTHGfF+0D42+Th12T94zsQ5Ueq vR4w== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id y25si30069996edc.377.2019.08.06.04.57.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Aug 2019 04:57:06 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) client-ip=195.135.220.15; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CF36EAD95; Tue, 6 Aug 2019 11:57:05 +0000 (UTC) Date: Tue, 6 Aug 2019 13:57:03 +0200 From: Michal Hocko To: Joel Fernandes Cc: linux-kernel@vger.kernel.org, Robin Murphy , Alexey Dobriyan , Andrew Morton , Borislav Petkov , Brendan Gregg , Catalin Marinas , Christian Hansen , dancol@google.com, fmayer@google.com, "H. Peter Anvin" , Ingo Molnar , Jonathan Corbet , Kees Cook , kernel-team@android.com, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Mike Rapoport , minchan@kernel.org, namhyung@google.com, paulmck@linux.ibm.com, Roman Gushchin , Stephen Rothwell , surenb@google.com, Thomas Gleixner , tkjos@google.com, Vladimir Davydov , Vlastimil Babka , Will Deacon Subject: Re: [PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE Message-ID: <20190806115703.GY11812@dhcp22.suse.cz> References: <20190805170451.26009-1-joel@joelfernandes.org> <20190805170451.26009-3-joel@joelfernandes.org> <20190806084203.GJ11812@dhcp22.suse.cz> <20190806103627.GA218260@google.com> <20190806104755.GR11812@dhcp22.suse.cz> <20190806111446.GA117316@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190806111446.GA117316@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 06-08-19 07:14:46, Joel Fernandes wrote: > On Tue, Aug 06, 2019 at 12:47:55PM +0200, Michal Hocko wrote: > > On Tue 06-08-19 06:36:27, Joel Fernandes wrote: > > > On Tue, Aug 06, 2019 at 10:42:03AM +0200, Michal Hocko wrote: > > > > On Mon 05-08-19 13:04:49, Joel Fernandes (Google) wrote: > > > > > This bit will be used by idle page tracking code to correctly identify > > > > > if a page that was swapped out was idle before it got swapped out. > > > > > Without this PTE bit, we lose information about if a page is idle or not > > > > > since the page frame gets unmapped. > > > > > > > > And why do we need that? Why cannot we simply assume all swapped out > > > > pages to be idle? They were certainly idle enough to be reclaimed, > > > > right? Or what does idle actualy mean here? > > > > > > Yes, but other than swapping, in Android a page can be forced to be swapped > > > out as well using the new hints that Minchan is adding? > > > > Yes and that is effectivelly making them idle, no? > > That depends on how you think of it. I would much prefer to have it documented so that I do not have to guess ;) > If you are thinking of a monitoring > process like a heap profiler, then from the heap profiler's (that only cares > about the process it is monitoring) perspective it will look extremely odd if > pages that are recently accessed by the process appear to be idle which would > falsely look like those processes are leaking memory. The reality being, > Android forced those pages into swap because of other reasons. I would like > for the swapping mechanism, whether forced swapping or memory reclaim, not to > interfere with the idle detection. Hmm, but how are you going to handle situation when the page is unmapped and refaulted again (e.g. a normal reclaim of a pagecache)? You are losing that information same was as in the swapout case, no? Or am I missing something? > This is just an effort to make the idle tracking a little bit better. We > would like to not lose the 'accessed' information of the pages. > > Initially, I had proposed what you are suggesting as well however the above > reasons made me to do it like this. Also Minchan and Konstantin suggested > this, so there are more people interested in the swap idle bit. Minchan, can > you provide more thoughts here? (He is on 2-week vacation from today so > hopefully replies before he vanishes ;-)). We can move on with the rest of the series in the mean time but I would like to see a proper justification for the swap entries and why they should be handled special. > Also assuming all swap pages as idle has other "semantic" issues. It is quite > odd if a swapped page is automatically marked as idle without userspace > telling it to. Consider the following set of events: 1. Userspace marks only > a certain memory region as idle. 2. Userspace reads back the bits > corresponding to a bigger region. Part of this bigger region is swapped. > Userspace expects all of the pages it did not mark, to have idle bit set to > '0' because it never marked them as idle. However if it is now surprised by > what it read back (not all '0' read back). Since a page is swapped, it will > be now marked "automatically" as idle as per your proposal, even if userspace > never marked it explicity before. This would be quite confusing/ambiguous. OK, I see. I guess the primary question I have is how do you distinguish Idle page which got unmapped and faulted in again from swapped out page and refaulted - including the time the pte is not present. -- Michal Hocko SUSE Labs