From: Michal Hocko <mhocko@kernel.org>
To: Jan Hadrava <had@kam.mff.cuni.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
wizards@kam.mff.cuni.cz, Kirill Tkhai <ktkhai@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Yang Shi <yang.shi@linux.alibaba.com>,
Shakeel Butt <shakeelb@google.com>
Subject: Re: [BUG]: mm/vmscan.c: shrink_slab does not work correctly with memcg disabled via commandline
Date: Thu, 1 Aug 2019 18:32:13 +0200 [thread overview]
Message-ID: <20190801163213.GO11627@dhcp22.suse.cz> (raw)
In-Reply-To: <20190801155434.2dftso2wuggfuv7a@kam.mff.cuni.cz>
On Thu 01-08-19 17:54:34, Jan Hadrava wrote:
> On Thu, Aug 01, 2019 at 04:06:10PM +0200, Michal Hocko wrote:
> > On Thu 01-08-19 15:42:50, Jan Hadrava wrote:
> > > There seems to be a bug in mm/vmscan.c shrink_slab function when kernel is
> > > compilled with CONFIG_MEMCG=y and it is then disabled at boot with commandline
> > > parameter cgroup_disable=memory. SLABs are then not getting shrinked if the
> > > system memory is consumed by userspace.
> >
> > This looks similar to http://lkml.kernel.org/r/1563385526-20805-1-git-send-email-yang.shi@linux.alibaba.com
> > although the culprit commit has been identified to be different. Could
> > you try it out please? Maybe we need more fixes.
>
> Yes, it is same.
I am happy to hear that!
> So my report is duplicate and I'm just bad in searching the
> archives, sorry.
No worries. Your bug report was really good with great level of details.
I wish all the bug reports were done so thoroughly.
> Just to be sure, i run my tests and patch proposed in the original thread
> solves my issue in all four affected stable releases:
Cc Andrew. I assume we can assume your Tested-by tag?
Thanks a lot!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-08-01 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 13:42 Jan Hadrava
2019-08-01 14:06 ` Michal Hocko
2019-08-01 15:54 ` Jan Hadrava
2019-08-01 16:32 ` Michal Hocko [this message]
2019-08-01 17:46 ` Jan Hadrava
2019-08-01 21:10 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801163213.GO11627@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=had@kam.mff.cuni.cz \
--cc=hannes@cmpxchg.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeelb@google.com \
--cc=wizards@kam.mff.cuni.cz \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox