From: Uladzislau Rezki <urezki@gmail.com>
To: sathyanarayanan kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Uladzislau Rezki <urezki@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] mm/vmalloc.c: Fix percpu free VM area search criteria
Date: Wed, 31 Jul 2019 14:04:11 +0200 [thread overview]
Message-ID: <20190731120411.42ij4che425a5x3w@pc636> (raw)
In-Reply-To: <63e48375-afa4-4ab6-240d-1633d7cc9ea4@linux.intel.com>
Hello, Sathyanarayanan.
> > Just to clarify, does it mean that on your setup you have only one area with the
> > 600000 size and 0xffff000000 offset?
> No, its 2 areas. with offset (0, ffff000000) and size (a00000, 600000).
> >
Thank you for clarification, that makes sense to me. I also can reproduce
that issue, so i agree with your patch. Basically we can skip free VA
block(that can fit) examining previous one(my fault), instead of moving
base downwards and recheck an area that did not fit.
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Appreciate you for fixing it!
--
Vlad Rezki
prev parent reply other threads:[~2019-07-31 12:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 23:21 sathyanarayanan.kuppuswamy
2019-07-30 20:46 ` Uladzislau Rezki
2019-07-30 20:54 ` Dave Hansen
2019-07-30 21:09 ` Dennis Zhou
2019-07-30 21:13 ` sathyanarayanan kuppuswamy
2019-07-30 21:55 ` Dennis Zhou
2019-07-30 22:25 ` sathyanarayanan kuppuswamy
2019-07-30 22:34 ` Uladzislau Rezki
2019-07-30 22:37 ` sathyanarayanan kuppuswamy
2019-07-31 12:04 ` Uladzislau Rezki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731120411.42ij4che425a5x3w@pc636 \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox