From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4196C7618B for ; Tue, 23 Jul 2019 15:18:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 676D620665 for ; Tue, 23 Jul 2019 15:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="NdFuRavX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 676D620665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EBB948E0008; Tue, 23 Jul 2019 11:18:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6A868E0006; Tue, 23 Jul 2019 11:18:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D33678E0008; Tue, 23 Jul 2019 11:18:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by kanga.kvack.org (Postfix) with ESMTP id 853E28E0006 for ; Tue, 23 Jul 2019 11:18:51 -0400 (EDT) Received: by mail-ed1-f70.google.com with SMTP id o13so28458711edt.4 for ; Tue, 23 Jul 2019 08:18:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:thread-topic :thread-index:date:message-id:references:in-reply-to:accept-language :content-language:content-id:content-transfer-encoding:mime-version; bh=VENW3byoNhHMP2GFW56MvPx/nwt1jcNE3YR8qDxw4pE=; b=rcvUygTLg0kdmls2JrITTlErx3mEVQu/nlm+ms/09UjCNn0s4mLsn08/Mow606/NrE mv4e3KNJ5tDTE9kSNIw13uvSeDUwwunAEsp9L7AgZzVt6747QBzU34Bu/5td1mFvrRwk iwgvEBFQQPPPiFsbXp+EUDg6+D7RSZrM5fgppxhaf8w2olGRFDmLy87BmCGjutVOVxDN VYMnDtxFaAN1ne3C9Ij6wWkGMU4pslHJla2O3zDhh8aGVH5JCmtEEAQ9n2D17v+1adBD HdePdiveUvBqdacNeY1pB0+0Ex/s6x0F7FF/bgZ2tKbyLXLFcHpzK4GfM+bXw2rOn7SJ zmtA== X-Gm-Message-State: APjAAAUve2RuNCZqaZ8KLWzMto7jhSt2kqj5YMgVSuX20rSnCLXGCSxs PsVXs3jv2b+dUT3WestePn/zgLGHXWVDZrA/0mm3cpijA0TSy/qb+AkJJyWuXAPtj/76mXh6Tqj Q5d/dLz/6luz9pio10Q0BmxPBVF6p+xVCdmugUzDYHmg/i4cN2A1FJZJeALCP4u5lIQ== X-Received: by 2002:a17:906:25c5:: with SMTP id n5mr56999593ejb.195.1563895131148; Tue, 23 Jul 2019 08:18:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqwr5fTwwNnzWqs1GjNXX0AbC8sEu7o6i5uw99N9az2vbd0d8nusr92oVlyR/IAykvdesLnG X-Received: by 2002:a17:906:25c5:: with SMTP id n5mr56999537ejb.195.1563895130539; Tue, 23 Jul 2019 08:18:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1563895130; cv=pass; d=google.com; s=arc-20160816; b=sVN8Utr5lqGpPMcCGY595KT6JjoaACIAzQSb5RfZNpBjvzrF8R1W4/Ups7FTLvlAQa BZh49iIsDtpN8h0tX1krXEn6GGe/QLtBd21qBvKPV9sQEgi3M2+/BwacsgF7+O7/3eW4 igzZYpDm85L0/i11QB/TPooaHmOAIz3OTz/c+gbm7ummpE0UroHDkD/4E/0EYudxbWmW AVC6WD00CqpwWhu0rjkgAy/rWg9KH67oDPtW7exiEiFvdcPgrJc7wR1iJxANm9+xxJjl l880hvpICydhRU9JwoPtMU2PIJatwjJQ3KaAESTgHZePKpAMbmO6ezGIgCuUnyVUW7QP zTjQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-id:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature; bh=VENW3byoNhHMP2GFW56MvPx/nwt1jcNE3YR8qDxw4pE=; b=fTMUxLUJSl5Wze6wn4NWfw+8dvzNphvIWAqh1xcVldZ9uSxUvH/eUdgNmV0zUgR4id 4ilbtPAnik5kp/7/dmRnOGJh4x7hfN7cL77ectubTFuzQCiTfGfQlGRnl2n3o4lBLNH1 pubWu3tsnqMOToJ2MrWMNep0c2kW7cZMQb6OUMUXpKQeORurmSoBrsJ/kbqUj5eShRzo z0EiNTRxHTAiSnmvb0IkNpUtTgCHJxIlZgXE6feiYMw9j6UQ6m3jRIoJfw7nNM5d5qi0 XXGn8LE9PgCLqwutZbXarkFLXI+VhDY1Ssd+Us2d3pwXEdiTPWhPuhTjMVZ/z5tH7aAC ZeEQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector2 header.b=NdFuRavX; arc=pass (i=1 spf=pass spfdomain=mellanox.com dkim=pass dkdomain=mellanox.com dmarc=pass fromdomain=mellanox.com); spf=pass (google.com: domain of jgg@mellanox.com designates 40.107.0.86 as permitted sender) smtp.mailfrom=jgg@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00086.outbound.protection.outlook.com. [40.107.0.86]) by mx.google.com with ESMTPS id j5si6298460ejb.211.2019.07.23.08.18.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 23 Jul 2019 08:18:50 -0700 (PDT) Received-SPF: pass (google.com: domain of jgg@mellanox.com designates 40.107.0.86 as permitted sender) client-ip=40.107.0.86; Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector2 header.b=NdFuRavX; arc=pass (i=1 spf=pass spfdomain=mellanox.com dkim=pass dkdomain=mellanox.com dmarc=pass fromdomain=mellanox.com); spf=pass (google.com: domain of jgg@mellanox.com designates 40.107.0.86 as permitted sender) smtp.mailfrom=jgg@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=njLfxdbQ2bOWUoWIcgWED+xXVmIsiOTGy/HCHyFkA251i7DHSEhUfA2ds4SWommNXw281OdOd2GNF7kE7d4Hb4MUxSdiTz7GkXqPgrEgP4ikpSZH5vZABd+bcvmPQSMQm/syDu+s4UuTGBZj3ZiRdGcqPsw+ZHLNLtExaaq3TINRVB2EjhkKCWQtOYijQ1C7pavGE6fV319dcHjHT74S0sDB0Uuhce2Z5/3gZDDPV/MHvif6U2gcmZ+Jft8/IaRW73V1toCUT/dPvabawsztPC6oGXX2AVt9J8bGiu89kyy2gJ0InCzfuQfQ2dMfYTgF6L74X03PvuGK3iA65NAbQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VENW3byoNhHMP2GFW56MvPx/nwt1jcNE3YR8qDxw4pE=; b=iRBQjI+bnm//M7Db3xWoKphCFaI2iMKQ9T4IxppJ9ADWRX0JdYf9OL/+vW4fUW3BYCCMAAgRfRJCaZYAbDUfvqIDFAQjzwulWND0WxsbE3LFmtPUkQ0jr3q+9dBBFp8ae+RSdOxR0zfber9jwFtfGIHFgptms8ExZSUXEICcl8BkqQxXrYiKorpuG7YnOZQ18TU1LknFGMdCzCkkl4I7AzOrNyc562jFwMEbfiJG+wx6EDEe5dU2OJDsD8w5yt7NywNJRsrab3tOwHJumq8p+m2c+5OZLZ3rSvCIqqFF8qfhFoGbDYQVjmtV9SBT0tEveN/CYAoZp603dwHZ1NWDBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VENW3byoNhHMP2GFW56MvPx/nwt1jcNE3YR8qDxw4pE=; b=NdFuRavXZS+NSMUta79Yf1lm+1J5GYaQfYxQhM6CMZ8i4/BuKiI6AgsmR7b+UDqUy3+iZqvm/QZI8k0Edhw2YxnyqYhbaJDQjRPfGv8s98MRAJAOzT6vNhEyNaxYyPTQEXhhnzAXFpjXjNLMerbcJbk+MXkjExA8F6PjU34pn28= Received: from VI1PR05MB4141.eurprd05.prod.outlook.com (10.171.182.144) by VI1PR05MB3279.eurprd05.prod.outlook.com (10.170.238.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.14; Tue, 23 Jul 2019 15:18:49 +0000 Received: from VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::5c6f:6120:45cd:2880]) by VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::5c6f:6120:45cd:2880%4]) with mapi id 15.20.2094.013; Tue, 23 Jul 2019 15:18:49 +0000 From: Jason Gunthorpe To: Christoph Hellwig CC: =?iso-8859-1?Q?J=E9r=F4me_Glisse?= , Ben Skeggs , Ralph Campbell , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 5/6] nouveau: return -EBUSY when hmm_range_wait_until_valid fails Thread-Topic: [PATCH 5/6] nouveau: return -EBUSY when hmm_range_wait_until_valid fails Thread-Index: AQHVQHIWAA6a741P4kaCXdSsPfFvyKbYUvMA Date: Tue, 23 Jul 2019 15:18:49 +0000 Message-ID: <20190723151846.GM15331@mellanox.com> References: <20190722094426.18563-1-hch@lst.de> <20190722094426.18563-6-hch@lst.de> In-Reply-To: <20190722094426.18563-6-hch@lst.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MN2PR05CA0021.namprd05.prod.outlook.com (2603:10b6:208:c0::34) To VI1PR05MB4141.eurprd05.prod.outlook.com (2603:10a6:803:4d::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [156.34.55.100] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b7040cd6-682a-46d5-76cb-08d70f811049 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB3279; x-ms-traffictypediagnostic: VI1PR05MB3279: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1227; x-forefront-prvs: 0107098B6C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(189003)(199004)(8936002)(5660300002)(11346002)(81166006)(476003)(316002)(66066001)(33656002)(478600001)(305945005)(76176011)(54906003)(68736007)(36756003)(8676002)(7736002)(81156014)(99286004)(102836004)(2616005)(86362001)(6506007)(25786009)(386003)(26005)(186003)(446003)(6436002)(52116002)(6486002)(229853002)(4744005)(6116002)(3846002)(486006)(1076003)(6512007)(2906002)(256004)(66446008)(53936002)(6246003)(71200400001)(14444005)(14454004)(4326008)(64756008)(66556008)(66476007)(66946007)(6916009)(71190400001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB3279;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: JfBmTD9q6uXParqZi+aVhS4o2+5jjCiKGeNSTX0ZzoIN8go6hy07el3TzKvxXAAq5IWqVmhvzfbU9UzShK21v7oz+13LE4JsjzS6cb18mvPRPszxDaJ4Jpd7JGjBXEO6hNKaYUckO/UEuO9igiDshJ/1HZsqlY3lid6/OK9m6yO41JCHPzFcRxdDVgJMJ78AgaU3t1QzOd8A+j5o/JOsYoufNDbpIYENk1EXCumD1eODiwLFEshdiK4vjIitiinLJrOHDjaXGUx/3rCofhnSuM8dHgjqYyzePXd7Nmh/iXZyHl5UlBMkfQsp7NzZX1XeLJM5guKW5b0DMWSsmFbhwAocVk1PQylWnAFmBpn95rx3Yl1peZCJEWKyH25RcSm6aGrQ1Yxh7eDiM4gvYaA/b3aTNCZywZnQCL+T4vdRnjU= Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7040cd6-682a-46d5-76cb-08d70f811049 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2019 15:18:49.5611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jgg@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3279 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 22, 2019 at 11:44:25AM +0200, Christoph Hellwig wrote: > -EAGAIN has a magic meaning for non-blocking faults, so don't overload > it. Given that the caller doesn't check for specific error codes this > change is purely cosmetic. >=20 > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Agree Reviewed-by: Jason Gunthorpe Jason