From: Andrew Morton <akpm@linux-foundation.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Sai Charan Sane <s.charan@samsung.com>,
mhocko@suse.com, tglx@linutronix.de, rppt@linux.vnet.ibm.com,
gregkh@linuxfoundation.org, joe@perches.com,
miles.chen@mediatek.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, a.sahrawat@samsung.com,
pankaj.m@samsung.com, v.narang@samsung.com
Subject: Re: [PATCH 1/1] mm/page_owner: store page_owner's gfp_mask in stackdepot itself
Date: Thu, 11 Jul 2019 18:04:17 -0700 [thread overview]
Message-ID: <20190711180417.1358ba8b359f68bbf92cf3c2@linux-foundation.org> (raw)
In-Reply-To: <24037235-2174-423f-9055-c6a49aa659e2@suse.cz>
On Mon, 17 Jun 2019 15:51:32 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:
> On 6/7/19 7:53 AM, Sai Charan Sane wrote:
> > Memory overhead of 4MB is reduced by storing gfp_mask in stackdepot along
> > with stacktrace. Stackdepot memory usage increased by ~100kb for 4GB of RAM.
> >
> > Page owner logs from dmesg:
> > Before patch:
> > allocated 20971520 bytes of page_ext
> > After patch:
> > allocated 16777216 bytes of page_ext
> >
> > Signed-off-by: Sai Charan Sane <s.charan@samsung.com>
>
> I don't know, this looks like unneeded abuse to me. In the debug
> scenario when someone boots a kernel with page_owner enabled, does 4MB
> out of 4GB RAM really make a difference?
Thanks. I'll drop this patch.
prev parent reply other threads:[~2019-07-12 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190607055426epcas5p24d6507b84fab957b8e0881d2ff727192@epcas5p2.samsung.com>
2019-06-07 5:53 ` Sai Charan Sane
2019-06-17 13:51 ` Vlastimil Babka
2019-07-12 1:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711180417.1358ba8b359f68bbf92cf3c2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.sahrawat@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=miles.chen@mediatek.com \
--cc=pankaj.m@samsung.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=s.charan@samsung.com \
--cc=tglx@linutronix.de \
--cc=v.narang@samsung.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox