From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-mm@kvack.org, linux-block@vger.kernel.org,
bvanassche@acm.org, axboe@kernel.dk,
Minwoo Im <minwoo.im.dev@gmail.com>
Subject: Re: [PATCH 2/5] block: update error message in submit_bio()
Date: Wed, 3 Jul 2019 09:43:39 +0900 [thread overview]
Message-ID: <20190703004339.GB19081@minwoo-desktop> (raw)
In-Reply-To: <20190701215726.27601-3-chaitanya.kulkarni@wdc.com>
On 19-07-01 14:57:23, Chaitanya Kulkarni wrote:
> The existing code in the submit_bio() relies on the op_is_write().
> op_is_write() checks for the last bit in the bio_op() and we only
> print WRITE or READ as a bio_op().
>
> It is hard to understand which bio op based on READ/WRITE in
> submit_bio() with addition of newly discussed REQ_OP_XXX. [1]
>
> Modify the error message in submit_bio() to print correct REQ_OP_XXX
> with the help of blk_op_str().
>
> [1] https://www.spinics.net/lists/linux-block/msg41884.html.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
It looks good to me.
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
next prev parent reply other threads:[~2019-07-03 0:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 21:57 [PATCH 0/5] block: udpate debug messages with blk_op_str() Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 1/5] block: update error message for bio_check_ro() Chaitanya Kulkarni
2019-07-03 0:42 ` Minwoo Im
2019-07-03 2:24 ` Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 2/5] block: update error message in submit_bio() Chaitanya Kulkarni
2019-07-03 0:43 ` Minwoo Im [this message]
2019-07-01 21:57 ` [PATCH 3/5] block: allow block_dump to print all REQ_OP_XXX Chaitanya Kulkarni
2019-07-03 0:50 ` Minwoo Im
2019-07-03 2:26 ` Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 4/5] mm: update block_dump comment Chaitanya Kulkarni
2019-07-08 18:49 ` Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 5/5] Documentation/laptop: add block_dump documentation Chaitanya Kulkarni
2019-07-08 18:49 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703004339.GB19081@minwoo-desktop \
--to=minwoo.im.dev@gmail.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox