From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: Christoph Hellwig <hch@lst.de>,
Ralph Campbell <rcampbell@nvidia.com>,
Jerome Glisse <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
"Felix.Kuehling@amd.com" <Felix.Kuehling@amd.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrea Arcangeli <aarcange@redhat.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [RFC] mm/hmm: pass mmu_notifier_range to sync_cpu_device_pagetables
Date: Wed, 3 Jul 2019 02:03:33 +0200 [thread overview]
Message-ID: <20190703000333.GA29316@lst.de> (raw)
In-Reply-To: <20190702225911.GA11833@mellanox.com>
On Tue, Jul 02, 2019 at 10:59:16PM +0000, Jason Gunthorpe wrote:
> > As this creates a somewhat hairy conflict for amdgpu, wouldn't it be
> > a better idea to wait a bit and apply it first thing for next merge
> > window?
>
> My thinking is that AMD GPU already has a monster conflict from this:
>
> int hmm_range_register(struct hmm_range *range,
> - struct mm_struct *mm,
> + struct hmm_mirror *mirror,
> unsigned long start,
> unsigned long end,
> unsigned page_shift);
Well, that seems like a relatively easy to fix conflict, at least as
long as you have the mirror easily available. The notifier change
on the other hand basically requires rewriting about two dozen lines
of code entirely.
next prev parent reply other threads:[~2019-07-03 0:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 0:14 Ralph Campbell
2019-06-08 9:10 ` Christoph Hellwig
2019-06-08 11:41 ` Jason Gunthorpe
2019-06-10 0:16 ` John Hubbard
2019-06-08 11:50 ` Jason Gunthorpe
2019-06-09 19:46 ` Ira Weiny
2019-07-02 19:53 ` Jason Gunthorpe
2019-07-02 20:11 ` Ralph Campbell
2019-07-02 22:49 ` Christoph Hellwig
2019-07-02 22:59 ` Jason Gunthorpe
2019-07-03 0:03 ` Christoph Hellwig [this message]
2019-07-03 2:27 ` Kuehling, Felix
2019-07-03 15:08 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703000333.GA29316@lst.de \
--to=hch@lst.de \
--cc=Felix.Kuehling@amd.com \
--cc=aarcange@redhat.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox