From: Michal Hocko <mhocko@kernel.org>
To: Alastair D'Silva <alastair@d-silva.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
Oscar Salvador <osalvador@suse.de>,
Mike Rapoport <rppt@linux.ibm.com>, Baoquan He <bhe@redhat.com>,
Wei Yang <richard.weiyang@gmail.com>,
Logan Gunthorpe <logang@deltatee.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/3] mm: Trigger bug on if a section is not found in __section_nr
Date: Mon, 1 Jul 2019 12:46:58 +0200 [thread overview]
Message-ID: <20190701104658.GA6549@dhcp22.suse.cz> (raw)
In-Reply-To: <833b9675bc363342827cb8f7c76ebb911f7f960d.camel@d-silva.org>
On Fri 28-06-19 10:46:28, Alastair D'Silva wrote:
[...]
> Given that there is already a VM_BUG_ON in the code, how do you feel
> about broadening the scope from 'VM_BUG_ON(!root)' to 'VM_BUG_ON(!root
> || (root_nr == NR_SECTION_ROOTS))'?
As far as I understand the existing VM_BUG_ON will hit when the
mem_section tree gets corrupted. This is a different situation to an
incorrect section given so I wouldn't really mix those two. And I still
do not see much point to protect from unexpected input parameter as this
is internal function as already pointed out.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-07-01 10:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 6:11 [PATCH v2 0/3] mm: Cleanup & allow modules to hotplug memory Alastair D'Silva
2019-06-26 6:11 ` [PATCH v2 1/3] mm: Trigger bug on if a section is not found in __section_nr Alastair D'Silva
2019-06-26 6:21 ` Michal Hocko
2019-06-26 6:27 ` Alastair D'Silva
2019-06-26 6:57 ` Michal Hocko
2019-06-27 0:50 ` Alastair D'Silva
2019-06-27 8:10 ` Michal Hocko
2019-06-28 0:46 ` Alastair D'Silva
2019-07-01 10:46 ` Michal Hocko [this message]
2019-07-02 4:13 ` Alastair D'Silva
2019-07-02 6:13 ` Michal Hocko
2019-07-02 6:16 ` Alastair D'Silva
2019-06-28 11:37 ` David Hildenbrand
2019-06-28 11:58 ` Michal Hocko
2019-06-26 6:11 ` [PATCH v2 2/3] mm: don't hide potentially null memmap pointer in sparse_remove_one_section Alastair D'Silva
2019-06-26 6:23 ` Michal Hocko
2019-06-26 6:30 ` Alastair D'Silva
2019-06-26 6:59 ` Michal Hocko
2019-06-28 11:29 ` David Hildenbrand
2019-06-26 6:11 ` [PATCH v2 3/3] mm: Don't manually decrement num_poisoned_pages Alastair D'Silva
2019-06-26 6:24 ` Michal Hocko
2019-06-28 11:29 ` David Hildenbrand
2019-06-26 7:57 ` [PATCH v2 0/3] mm: Cleanup & allow modules to hotplug memory Christoph Hellwig
2019-06-27 0:51 ` Alastair D'Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701104658.GA6549@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alastair@d-silva.org \
--cc=bhe@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@oracle.com \
--cc=rafael@kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox