From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Shakeel Butt <shakeelb@google.com>, linux-mm@kvack.org
Subject: Re: [PATCH v3 3/3] oom: decouple mems_allowed from oom_unkillable_task
Date: Wed, 26 Jun 2019 14:15:19 +0200 [thread overview]
Message-ID: <20190626121519.GS17798@dhcp22.suse.cz> (raw)
In-Reply-To: <3ec3304f-7d3f-cb08-5635-12c6b9c0905c@i-love.sakura.ne.jp>
On Wed 26-06-19 20:46:02, Tetsuo Handa wrote:
> On 2019/06/26 19:47, Michal Hocko wrote:
> > On Wed 26-06-19 19:19:20, Tetsuo Handa wrote:
> >> Is "mempolicy_nodemask_intersects(tsk) returning true when tsk already
> >> passed mpol_put_task_policy(tsk) in do_exit()" what we want?
> >>
> >> If tsk is an already exit()ed thread group leader, that thread group is
> >> needlessly selected by the OOM killer because mpol_put_task_policy()
> >> returns true?
> >
> > I am sorry but I do not really see how this is related to this
> > particular patch. Are you suggesting that has_intersects_mems_allowed is
> > racy? More racy now?
>
> I'm suspecting the correctness of has_intersects_mems_allowed().
THen this deserves an own email thread. Thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-06-26 12:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 21:26 [PATCH v3 1/3] mm, oom: refactor dump_tasks for memcg OOMs Shakeel Butt
2019-06-24 21:26 ` [PATCH v3 2/3] mm, oom: remove redundant task_in_mem_cgroup() check Shakeel Butt
2019-06-26 6:38 ` Michal Hocko
2019-06-28 2:12 ` Shakeel Butt
2019-06-24 21:26 ` [PATCH v3 3/3] oom: decouple mems_allowed from oom_unkillable_task Shakeel Butt
2019-06-26 6:55 ` Michal Hocko
2019-06-26 10:19 ` Tetsuo Handa
2019-06-26 10:47 ` Michal Hocko
2019-06-26 11:46 ` Tetsuo Handa
2019-06-26 12:15 ` Michal Hocko [this message]
2019-06-28 2:17 ` Shakeel Butt
2019-06-26 9:12 ` Hillf Danton
2019-06-26 9:18 ` Michal Hocko
2019-06-26 19:47 ` Roman Gushchin
2019-06-26 14:04 Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626121519.GS17798@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox