From: Michal Hocko <mhocko@kernel.org>
To: Hillf Danton <hdanton@sina.com>
Cc: Shakeel Butt <shakeelb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>,
David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Paul Jackson <pj@sgi.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
syzbot+d0fc9d3c166bc5e4a94b@syzkaller.appspotmail.com
Subject: Re: [PATCH v3 3/3] oom: decouple mems_allowed from oom_unkillable_task
Date: Wed, 26 Jun 2019 11:18:17 +0200 [thread overview]
Message-ID: <20190626091759.GP17798@dhcp22.suse.cz> (raw)
In-Reply-To: <20190624212631.87212-3-shakeelb@google.com>
On Wed 26-06-19 17:12:10, Hillf Danton wrote:
>
> On Mon, 24 Jun 2019 14:27:11 -0700 (PDT) Shakeel Butt wrote:
> >
> > @@ -1085,7 +1091,8 @@ bool out_of_memory(struct oom_control *oc)
> > check_panic_on_oom(oc, constraint);
> >
> > if (!is_memcg_oom(oc) && sysctl_oom_kill_allocating_task &&
> > - current->mm && !oom_unkillable_task(current, oc->nodemask) &&
> > + current->mm && !oom_unkillable_task(current) &&
> > + has_intersects_mems_allowed(current, oc) &&
> For what?
This is explained in the changelog I believe - see the initial section
about the history and motivation for the check. This patch removes it
from oom_unkillable_task so we have to check it explicitly here.
> > current->signal->oom_score_adj != OOM_SCORE_ADJ_MIN) {
> > get_task_struct(current);
> > oc->chosen = current;
> > --
> > 2.22.0.410.gd8fdbe21b5-goog
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-06-26 9:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 21:26 [PATCH v3 1/3] mm, oom: refactor dump_tasks for memcg OOMs Shakeel Butt
2019-06-24 21:26 ` [PATCH v3 2/3] mm, oom: remove redundant task_in_mem_cgroup() check Shakeel Butt
2019-06-26 6:38 ` Michal Hocko
2019-06-28 2:12 ` Shakeel Butt
2019-06-24 21:26 ` [PATCH v3 3/3] oom: decouple mems_allowed from oom_unkillable_task Shakeel Butt
2019-06-26 6:55 ` Michal Hocko
2019-06-26 10:19 ` Tetsuo Handa
2019-06-26 10:47 ` Michal Hocko
2019-06-26 11:46 ` Tetsuo Handa
2019-06-26 12:15 ` Michal Hocko
2019-06-28 2:17 ` Shakeel Butt
2019-06-26 9:12 ` Hillf Danton
2019-06-26 9:18 ` Michal Hocko [this message]
2019-06-26 19:47 ` Roman Gushchin
2019-06-26 14:04 Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626091759.GP17798@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pj@sgi.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=syzbot+d0fc9d3c166bc5e4a94b@syzkaller.appspotmail.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox