From: kbuild test robot <lkp@intel.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: kbuild-all@01.org, akpm@linux-foundation.org, mhocko@suse.com,
linux-mm@kvack.org, shaoyafang@didiglobal.com,
Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [PATCH] mm/vmscan: expose cgroup_ino for shrink slab tracepoints
Date: Mon, 24 Jun 2019 11:12:19 +0800 [thread overview]
Message-ID: <201906241129.NkRY68iv%lkp@intel.com> (raw)
In-Reply-To: <1561285353-3986-1-git-send-email-laoar.shao@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 7705 bytes --]
Hi Yafang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/perf/core]
[also build test ERROR on v5.2-rc6 next-20190621]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Yafang-Shao/mm-vmscan-expose-cgroup_ino-for-shrink-slab-tracepoints/20190624-042930
config: x86_64-defconfig (attached as .config)
compiler: clang version 9.0.0 (git://gitmirror/llvm_project 1fa07ebd929383f769994818c3f8c55919bf0a0e)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from mm/vmscan.c:64:
In file included from include/trace/events/vmscan.h:504:
In file included from include/trace/define_trace.h:102:
In file included from include/trace/trace_events.h:740:
>> include/trace/events/vmscan.h:217:45: error: incomplete definition of type 'struct mem_cgroup'
__entry->cgroup_ino = cgroup_ino(sc->memcg->css.cgroup);
~~~~~~~~~^
include/trace/trace_events.h:687:33: note: expanded from macro 'TP_fast_assign'
#define TP_fast_assign(args...) args
^~~~
include/trace/trace_events.h:78:16: note: expanded from macro 'TRACE_EVENT'
PARAMS(assign), \
^~~~~~
include/linux/tracepoint.h:95:25: note: expanded from macro 'PARAMS'
#define PARAMS(args...) args
^~~~
include/trace/trace_events.h:720:4: note: expanded from macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
include/linux/mm_types.h:27:8: note: forward declaration of 'struct mem_cgroup'
struct mem_cgroup;
^
In file included from mm/vmscan.c:64:
In file included from include/trace/events/vmscan.h:504:
In file included from include/trace/define_trace.h:102:
In file included from include/trace/trace_events.h:740:
include/trace/events/vmscan.h:260:45: error: incomplete definition of type 'struct mem_cgroup'
__entry->cgroup_ino = cgroup_ino(sc->memcg->css.cgroup);
~~~~~~~~~^
include/trace/trace_events.h:687:33: note: expanded from macro 'TP_fast_assign'
#define TP_fast_assign(args...) args
^~~~
include/trace/trace_events.h:78:16: note: expanded from macro 'TRACE_EVENT'
PARAMS(assign), \
^~~~~~
include/linux/tracepoint.h:95:25: note: expanded from macro 'PARAMS'
#define PARAMS(args...) args
^~~~
include/trace/trace_events.h:720:4: note: expanded from macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
include/linux/mm_types.h:27:8: note: forward declaration of 'struct mem_cgroup'
struct mem_cgroup;
^
In file included from mm/vmscan.c:64:
In file included from include/trace/events/vmscan.h:504:
In file included from include/trace/define_trace.h:103:
In file included from include/trace/perf.h:90:
>> include/trace/events/vmscan.h:217:45: error: incomplete definition of type 'struct mem_cgroup'
__entry->cgroup_ino = cgroup_ino(sc->memcg->css.cgroup);
~~~~~~~~~^
include/trace/trace_events.h:687:33: note: expanded from macro 'TP_fast_assign'
#define TP_fast_assign(args...) args
^~~~
include/trace/trace_events.h:78:16: note: expanded from macro 'TRACE_EVENT'
PARAMS(assign), \
^~~~~~
include/linux/tracepoint.h:95:25: note: expanded from macro 'PARAMS'
#define PARAMS(args...) args
^~~~
include/trace/perf.h:66:4: note: expanded from macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
include/linux/mm_types.h:27:8: note: forward declaration of 'struct mem_cgroup'
struct mem_cgroup;
^
In file included from mm/vmscan.c:64:
In file included from include/trace/events/vmscan.h:504:
In file included from include/trace/define_trace.h:103:
In file included from include/trace/perf.h:90:
include/trace/events/vmscan.h:260:45: error: incomplete definition of type 'struct mem_cgroup'
__entry->cgroup_ino = cgroup_ino(sc->memcg->css.cgroup);
~~~~~~~~~^
include/trace/trace_events.h:687:33: note: expanded from macro 'TP_fast_assign'
#define TP_fast_assign(args...) args
^~~~
include/trace/trace_events.h:78:16: note: expanded from macro 'TRACE_EVENT'
PARAMS(assign), \
^~~~~~
include/linux/tracepoint.h:95:25: note: expanded from macro 'PARAMS'
#define PARAMS(args...) args
^~~~
include/trace/perf.h:66:4: note: expanded from macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^~~~~~
include/linux/mm_types.h:27:8: note: forward declaration of 'struct mem_cgroup'
struct mem_cgroup;
^
4 errors generated.
vim +217 include/trace/events/vmscan.h
184
185 TRACE_EVENT(mm_shrink_slab_start,
186 TP_PROTO(struct shrinker *shr, struct shrink_control *sc,
187 long nr_objects_to_shrink, unsigned long cache_items,
188 unsigned long long delta, unsigned long total_scan,
189 int priority),
190
191 TP_ARGS(shr, sc, nr_objects_to_shrink, cache_items, delta, total_scan,
192 priority),
193
194 TP_STRUCT__entry(
195 __field(struct shrinker *, shr)
196 __field(void *, shrink)
197 __field(int, nid)
198 __field(long, nr_objects_to_shrink)
199 __field(gfp_t, gfp_flags)
200 __field(unsigned long, cache_items)
201 __field(unsigned long long, delta)
202 __field(unsigned long, total_scan)
203 __field(int, priority)
204 __field(unsigned int, cgroup_ino)
205 ),
206
207 TP_fast_assign(
208 __entry->shr = shr;
209 __entry->shrink = shr->scan_objects;
210 __entry->nid = sc->nid;
211 __entry->nr_objects_to_shrink = nr_objects_to_shrink;
212 __entry->gfp_flags = sc->gfp_mask;
213 __entry->cache_items = cache_items;
214 __entry->delta = delta;
215 __entry->total_scan = total_scan;
216 __entry->priority = priority;
> 217 __entry->cgroup_ino = cgroup_ino(sc->memcg->css.cgroup);
218 ),
219
220 TP_printk("%pS %p: nid: %d objects to shrink %ld gfp_flags %s cache items %ld delta %lld total_scan %ld priority %d cgroup_ino %u",
221 __entry->shrink,
222 __entry->shr,
223 __entry->nid,
224 __entry->nr_objects_to_shrink,
225 show_gfp_flags(__entry->gfp_flags),
226 __entry->cache_items,
227 __entry->delta,
228 __entry->total_scan,
229 __entry->priority,
230 __entry->cgroup_ino)
231 );
232
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28295 bytes --]
prev parent reply other threads:[~2019-06-24 3:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 10:22 Yafang Shao
2019-06-23 22:58 ` kbuild test robot
2019-06-24 1:28 ` kbuild test robot
2019-06-24 3:12 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201906241129.NkRY68iv%lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@01.org \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=shaoyafang@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox