From: Andrew Morton <akpm@linux-foundation.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: "Tetsuo Handa" <penguin-kernel@i-love.sakura.ne.jp>,
"Michal Hocko" <mhocko@kernel.org>,
syzbot <syzbot+d0fc9d3c166bc5e4a94b@syzkaller.appspotmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Roman Gushchin" <guro@fb.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"Linux MM" <linux-mm@kvack.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
yuzhoujian@didichuxing.com
Subject: Re: general protection fault in oom_unkillable_task
Date: Mon, 17 Jun 2019 18:45:47 -0700 [thread overview]
Message-ID: <20190617184547.5b81f7df81af46e86441ba8c@linux-foundation.org> (raw)
In-Reply-To: <CALvZod5VPLVEwRzy83+wT=aA8vsrUkvoJJZvmQxyv4YbXvrQWw@mail.gmail.com>
On Mon, 17 Jun 2019 06:23:07 -0700 Shakeel Butt <shakeelb@google.com> wrote:
> > Here is a patch to use CSS_TASK_ITER_PROCS.
> >
> > From 415e52cf55bc4ad931e4f005421b827f0b02693d Mon Sep 17 00:00:00 2001
> > From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > Date: Mon, 17 Jun 2019 00:09:38 +0900
> > Subject: [PATCH] mm: memcontrol: Use CSS_TASK_ITER_PROCS at mem_cgroup_scan_tasks().
> >
> > Since commit c03cd7738a83b137 ("cgroup: Include dying leaders with live
> > threads in PROCS iterations") corrected how CSS_TASK_ITER_PROCS works,
> > mem_cgroup_scan_tasks() can use CSS_TASK_ITER_PROCS in order to check
> > only one thread from each thread group.
> >
> > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>
> Reviewed-by: Shakeel Butt <shakeelb@google.com>
>
> Why not add the reproducer in the commit message?
That would be nice.
More nice would be, as always, a descriptoin of the user-visible impact
of the patch.
As I understand it, it's just a bit of a cleanup against current
mainline but without this patch in place, Shakeel's "mm, oom: refactor
dump_tasks for memcg OOMs" will cause kernel crashes. Correct?
next prev parent reply other threads:[~2019-06-18 1:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 1:08 syzbot
2019-06-15 1:10 ` Tetsuo Handa
2019-06-15 15:59 ` Tetsuo Handa
2019-06-15 3:15 ` Shakeel Butt
2019-06-15 13:49 ` Michal Hocko
2019-06-15 16:11 ` Shakeel Butt
2019-06-15 16:48 ` Tetsuo Handa
2019-06-15 18:50 ` Shakeel Butt
2019-06-15 21:33 ` Tetsuo Handa
2019-06-16 7:37 ` Tetsuo Handa
2019-06-16 15:13 ` Tetsuo Handa
2019-06-17 6:31 ` Michal Hocko
2019-06-17 13:23 ` Shakeel Butt
2019-06-18 1:45 ` Andrew Morton [this message]
2019-06-18 4:21 ` Shakeel Butt
2019-06-17 6:33 ` Michal Hocko
2019-06-17 9:56 ` Tetsuo Handa
2019-06-17 10:13 ` Michal Hocko
2019-06-16 5:48 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617184547.5b81f7df81af46e86441ba8c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=shakeelb@google.com \
--cc=syzbot+d0fc9d3c166bc5e4a94b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yuzhoujian@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox