From: Tejun Heo <tj@kernel.org>
To: Xi Ruoyao <xry111@mengyan1223.wang>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, dschatzberg@fb.com
Subject: Re: [PATCH RFC] mm: memcontrol: add cgroup v2 interface to read memory watermark
Date: Sat, 15 Jun 2019 09:20:04 -0700 [thread overview]
Message-ID: <20190615162004.GG657710@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <0f1be041f8de95603753ffe989bd25069efa13bb.camel@mengyan1223.wang>
On Sat, Jun 15, 2019 at 04:20:04PM +0800, Xi Ruoyao wrote:
> Introduce a control file memory.watermark showing the watermark
> consumption of the cgroup and its descendants, in bytes.
>
> Signed-off-by: Xi Ruoyao <xry111@mengyan1223.wang>
Memory usage w/o pressure metric isn't all that useful and reporting
just the historical maximum of memory.current can be outright
misleading. The use case of determining maximum amount of required
memory is legit but it needs to maintain sustained positive pressure
while taking measurements. There are efforts on this front, so let's
not merge this one for now.
Nacked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2019-06-15 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 8:20 Xi Ruoyao
2019-06-15 16:20 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190615162004.GG657710@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=dschatzberg@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=xry111@mengyan1223.wang \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox