From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Michal Koutný" <mkoutny@suse.com>,
linux-mm@kvack.org, "Laurent Dufour" <ldufour@linux.ibm.com>,
linux-kernel@vger.kernel.org,
"Kirill Tkhai" <ktkhai@virtuozzo.com>
Subject: Re: [RFC PATCH] binfmt_elf: Protect mm_struct access with mmap_sem
Date: Wed, 12 Jun 2019 21:04:15 +0300 [thread overview]
Message-ID: <20190612180415.GE23535@uranus.lan> (raw)
In-Reply-To: <20190612175159.GF32656@bombadil.infradead.org>
On Wed, Jun 12, 2019 at 10:51:59AM -0700, Matthew Wilcox wrote:
> On Wed, Jun 12, 2019 at 07:29:15PM +0200, Michal Koutný wrote:
> > On Wed, Jun 12, 2019 at 10:00:34AM -0700, Matthew Wilcox <willy@infradead.org> wrote:
> > > On Wed, Jun 12, 2019 at 04:28:11PM +0200, Michal Koutný wrote:
> > > > - /* N.B. passed_fileno might not be initialized? */
> > > > +
> > >
> > > Why did you delete this comment?
> > The variable got removed in
> > d20894a23708 ("Remove a.out interpreter support in ELF loader")
> > so it is not relevant anymore.
>
> Better put that in the changelog for v2 then. or even make it a
> separate patch.
Just updated changelog should be fine, I guess. A separate commit
just to remove an obsolete comment is too much.
next prev parent reply other threads:[~2019-06-12 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 14:28 Michal Koutný
2019-06-12 17:00 ` Matthew Wilcox
2019-06-12 17:29 ` Michal Koutný
2019-06-12 17:51 ` Matthew Wilcox
2019-06-12 18:04 ` Cyrill Gorcunov [this message]
2019-06-12 18:02 ` Cyrill Gorcunov
2019-06-13 10:47 ` [RFC PATCH v2] " Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612180415.GE23535@uranus.lan \
--to=gorcunov@gmail.com \
--cc=ktkhai@virtuozzo.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mkoutny@suse.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox