From: Ira Weiny <ira.weiny@intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Pingfan Liu <kernelfans@gmail.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <willy@infradead.org>,
John Hubbard <jhubbard@nvidia.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Keith Busch <keith.busch@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast()
Date: Mon, 3 Jun 2019 16:56:10 -0700 [thread overview]
Message-ID: <20190603235610.GB29018@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20190603164206.GB29719@infradead.org>
On Mon, Jun 03, 2019 at 09:42:06AM -0700, Christoph Hellwig wrote:
> > +#if defined(CONFIG_CMA)
>
> You can just use #ifdef here.
>
> > +static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
> > + struct page **pages)
>
> Please use two instead of one tab to indent the continuing line of
> a function declaration.
>
> > +{
> > + if (unlikely(gup_flags & FOLL_LONGTERM)) {
>
> IMHO it would be a little nicer if we could move this into the caller.
FWIW we already had this discussion and thought it better to put this here.
https://lkml.org/lkml/2019/5/30/1565
Ira
[PS John for some reason your responses don't appear in that thread?]
next prev parent reply other threads:[~2019-06-03 23:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 6:34 Pingfan Liu
2019-06-03 6:34 ` [PATCHv2 2/2] mm/gup: rename nr as nr_pinned " Pingfan Liu
2019-06-03 15:02 ` Ira Weiny
2019-06-03 15:00 ` [PATCHv2 1/2] mm/gup: fix omission of check on FOLL_LONGTERM " Ira Weiny
2019-06-03 16:42 ` Christoph Hellwig
2019-06-03 18:43 ` John Hubbard
2019-06-03 23:56 ` Ira Weiny [this message]
2019-06-04 7:08 ` Christoph Hellwig
2019-06-04 7:24 ` Pingfan Liu
2019-06-04 16:55 ` Ira Weiny
2019-06-04 19:38 ` John Hubbard
2019-06-04 19:29 ` John Hubbard
2019-06-04 7:13 ` Pingfan Liu
2019-06-04 7:17 ` Christoph Hellwig
2019-06-04 7:20 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603235610.GB29018@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=jhubbard@nvidia.com \
--cc=keith.busch@intel.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox