From: Andrew Morton <akpm@linux-foundation.org>
To: kbuild test robot <lkp@intel.com>
Cc: Kairui Song <kasong@redhat.com>,
kbuild-all@01.org, Bhupesh Sharma <bhsharma@redhat.com>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 3906/3985] fs/proc/vmcore.c:59:43: error: expected ')' before 'bool'
Date: Mon, 3 Jun 2019 15:14:17 -0700 [thread overview]
Message-ID: <20190603151417.2a637b3e73207802e2829606@linux-foundation.org> (raw)
In-Reply-To: <201906030232.nmc5yeSR%lkp@intel.com>
On Mon, 3 Jun 2019 02:35:34 +0800 kbuild test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 3c09c1950c8483eeeb4bf9615ecdcec7234c6790
> commit: 0f5a18299c6b7e1d6900d950006d3fad329f6c6e [3906/3985] vmcore: Add a kernel parameter novmcoredd
> config: x86_64-randconfig-g2-201921 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> git checkout 0f5a18299c6b7e1d6900d950006d3fad329f6c6e
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> >> fs/proc/vmcore.c:59:43: error: expected ')' before 'bool'
> core_param(novmcoredd, vmcoredd_disabled, bool, 0);
> ^~~~
>
> vim +59 fs/proc/vmcore.c
>
> 57
> 58 static bool vmcoredd_disabled;
> > 59 core_param(novmcoredd, vmcoredd_disabled, bool, 0);
> 60 #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
> 61
--- a/fs/proc/vmcore.c~vmcore-add-a-kernel-parameter-novmcoredd-fix-fix
+++ a/fs/proc/vmcore.c
@@ -21,6 +21,7 @@
#include <linux/init.h>
#include <linux/crash_dump.h>
#include <linux/list.h>
+#include <linux/moduleparam.h>
#include <linux/mutex.h>
#include <linux/vmalloc.h>
#include <linux/pagemap.h>
_
prev parent reply other threads:[~2019-06-03 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 18:35 kbuild test robot
2019-06-03 22:14 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603151417.2a637b3e73207802e2829606@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bhsharma@redhat.com \
--cc=kasong@redhat.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox