From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hillf Danton <hdanton@sina.com>,
Mel Gorman <mgorman@techsingularity.net>,
linux-mm@kvack.org, Minchan Kim <minchan@kernel.org>,
Yang Shi <yang.shi@linux.alibaba.com>
Subject: Re: [PATCH] mm: vmscan: Add warn on inadvertently reclaiming mapped page
Date: Wed, 29 May 2019 13:01:44 -0400 [thread overview]
Message-ID: <20190529170144.GA30884@cmpxchg.org> (raw)
In-Reply-To: <20190528212257.f795b405ac1b88d72bb3fa2f@linux-foundation.org>
On Tue, May 28, 2019 at 09:22:57PM -0700, Andrew Morton wrote:
> On Sun, 26 May 2019 14:23:53 +0800 Hillf Danton <hdanton@sina.com> wrote:
>
> > In the function isolate_lru_pages(), we check scan_control::may_unmap and set
> > isolation mode accordingly in order to not isolate from the lru list any page
> > that does not match the isolation mode. For example, we should skip all sill
> > mapped pages if isolation mode is set to be ISOLATE_UNMAPPED.
> >
> > So complain, while scanning the isolated pages, about the very unlikely event
> > that we hit a mapped page that we should never have isolated. Note no change
> > is added in the current scanning behavior without VM debug configured.
>
> The patch is inoffensive enough, but one wonders what inspired it. Do
> you have reason to believe that this will trigger?
I don't think this patch makes sense.
There isn't anything preventing someone from mapping the page between
the LRU isolation and shrink_page_list(). The isolation filter is only
an optimization to reduce unnecessary LRU churn, not a guarantee.
prev parent reply other threads:[~2019-05-29 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190526062353.14684-1-hdanton@sina.com>
2019-05-27 7:42 ` Yang Shi
2019-05-29 4:22 ` Andrew Morton
2019-05-29 17:01 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529170144.GA30884@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=hdanton@sina.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox