From: Andrew Morton <akpm@linux-foundation.org>
To: kbuild test robot <lkp@intel.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [liu-song6-linux:uprobe-thp 92/185] arch/arm64/include/asm/pgtable.h:93:27: error: expected identifier or '(' before '!' token
Date: Wed, 29 May 2019 14:49:09 -0700 [thread overview]
Message-ID: <20190529144909.5611892fc595554301780597@linux-foundation.org> (raw)
In-Reply-To: <201905291549.xlVZd4Ss%lkp@intel.com>
On Wed, 29 May 2019 15:54:52 +0800 kbuild test robot <lkp@intel.com> wrote:
> tree: https://github.com/liu-song-6/linux.git uprobe-thp
> head: 950e997c620db50b4f7e578631f6c8b0e1315778
> commit: 5760548d3bd197b0858ccaf3ec8039aedba5832f [92/185] arm64: mm: Implement pte_devmap support
> config: arm64-allnoconfig (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 7.4.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 5760548d3bd197b0858ccaf3ec8039aedba5832f
> # save the attached .config to linux build tree
> GCC_VERSION=7.4.0 make.cross ARCH=arm64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>):
>
> In file included from include/linux/mm.h:99:0,
> from arch/arm64/kernel/asm-offsets.c:23:
> >> arch/arm64/include/asm/pgtable.h:93:27: error: expected identifier or '(' before '!' token
> #define pte_devmap(pte) (!!(pte_val(pte) & PTE_DEVMAP))
> ^
> >> arch/arm64/include/asm/pgtable.h:390:26: note: in expansion of macro 'pte_devmap'
> #define pmd_devmap(pmd) pte_devmap(pmd_pte(pmd))
> ^~~~~~~~~~
> >> include/linux/mm.h:540:19: note: in expansion of macro 'pmd_devmap'
> static inline int pmd_devmap(pmd_t pmd)
> ^~~~~~~~~~
> In file included from arch/arm64/kernel/asm-offsets.c:23:0:
> >> include/linux/mm.h:544:19: error: redefinition of 'pud_devmap'
> static inline int pud_devmap(pud_t pud)
> ^~~~~~~~~~
> In file included from include/linux/mm.h:99:0,
> from arch/arm64/kernel/asm-offsets.c:23:
> arch/arm64/include/asm/pgtable.h:549:19: note: previous definition of 'pud_devmap' was here
> static inline int pud_devmap(pud_t pud)
> ^~~~~~~~~~
> In file included from arch/arm64/kernel/asm-offsets.c:23:0:
> >> include/linux/mm.h:548:19: error: redefinition of 'pgd_devmap'
> static inline int pgd_devmap(pgd_t pgd)
> ^~~~~~~~~~
> In file included from include/linux/mm.h:99:0,
> from arch/arm64/kernel/asm-offsets.c:23:
> arch/arm64/include/asm/pgtable.h:641:19: note: previous definition of 'pgd_devmap' was here
> static inline int pgd_devmap(pgd_t pgd)
> ^~~~~~~~~~
Thanks. I guess we need some `#if defined(CONFIG_ARCH_HAS_PTE_DEVMAP)
&& defined(CONFIG_TRANSPARENT_HUGEPAGE)' sprinkled around. I'll drop
this copy.
prev parent reply other threads:[~2019-05-29 21:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 7:54 kbuild test robot
2019-05-29 21:49 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529144909.5611892fc595554301780597@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox