From: kbuild test robot <lkp@intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: [liu-song6-linux:uprobe-thp 138/185] drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h:299:0: warning: "BITS_TO_BYTES" redefined
Date: Wed, 29 May 2019 10:57:59 +0800 [thread overview]
Message-ID: <201905291049.UVeshpZJ%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4321 bytes --]
tree: https://github.com/liu-song-6/linux.git uprobe-thp
head: 757cb898eb3096f4ed9487b503748d6e3a4d3332
commit: fda08ae863e2fe70adced116d0d7f2ab3b75f219 [138/185] bitops: more BITS_TO_* macros
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout fda08ae863e2fe70adced116d0d7f2ab3b75f219
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:30:0:
>> drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h:299:0: warning: "BITS_TO_BYTES" redefined
#define BITS_TO_BYTES(x) ((x)/8)
In file included from include/linux/bitmap.h:8:0,
from include/linux/ethtool.h:16,
from drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:22:
include/linux/bitops.h:11:0: note: this is the location of the previous definition
#define BITS_TO_BYTES(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(char))
vim +/BITS_TO_BYTES +299 drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h
619c5cb6 drivers/net/bnx2x/bnx2x_init.h Vlad Zolotarov 2011-06-14 281
619c5cb6 drivers/net/bnx2x/bnx2x_init.h Vlad Zolotarov 2011-06-14 282
dbedd44e drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Joe Perches 2015-03-06 283 /* congestion management port init api description
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 284 * the api works as follows:
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 285 * the driver should pass the cmng_init_input struct, the port_init function
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 286 * will prepare the required internal ram structure which will be passed back
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 287 * to the driver (cmng_init) that will write it into the internal ram.
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 288 *
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 289 * IMPORTANT REMARKS:
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 290 * 1. the cmng_init struct does not represent the contiguous internal ram
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 291 * structure. the driver should use the XSTORM_CMNG_PERPORT_VARS_OFFSET
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 292 * offset in order to write the port sub struct and the
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 293 * PFID_FROM_PORT_AND_VNIC offset for writing the vnic sub struct (in other
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 294 * words - don't use memcpy!).
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 295 * 2. although the cmng_init struct is filled for the maximal vnic number
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 296 * possible, the driver should only write the valid vnics into the internal
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 297 * ram according to the appropriate port mode.
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 298 */
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 @299 #define BITS_TO_BYTES(x) ((x)/8)
b475d78f drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h Yuval Mintz 2012-04-03 300
:::::: The code at line 299 was first introduced by commit
:::::: b475d78f464195cbdeeda0d80a2ffbd54653a4bd bnx2x: congestion management re-organization
:::::: TO: Yuval Mintz <yuvalmin@broadcom.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47396 bytes --]
reply other threads:[~2019-05-29 2:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905291049.UVeshpZJ%lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox