From: Roman Gushchin <guro@fb.com>
To: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Hillf Danton <hdanton@sina.com>, Michal Hocko <mhocko@suse.com>,
Matthew Wilcox <willy@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Garnier <thgarnie@google.com>,
"Oleksiy Avramchenko" <oleksiy.avramchenko@sonymobile.com>,
Steven Rostedt <rostedt@goodmis.org>,
Joel Fernandes <joelaf@google.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v3 1/4] mm/vmap: remove "node" argument
Date: Tue, 28 May 2019 22:33:14 +0000 [thread overview]
Message-ID: <20190528223309.GF27847@tower.DHCP.thefacebook.com> (raw)
In-Reply-To: <20190527093842.10701-2-urezki@gmail.com>
On Mon, May 27, 2019 at 11:38:39AM +0200, Uladzislau Rezki (Sony) wrote:
> Remove unused argument from the __alloc_vmap_area() function.
>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> ---
> mm/vmalloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index c42872ed82ac..ea1b65fac599 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -985,7 +985,7 @@ adjust_va_to_fit_type(struct vmap_area *va,
> */
> static __always_inline unsigned long
> __alloc_vmap_area(unsigned long size, unsigned long align,
> - unsigned long vstart, unsigned long vend, int node)
> + unsigned long vstart, unsigned long vend)
> {
> unsigned long nva_start_addr;
> struct vmap_area *va;
> @@ -1062,7 +1062,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
> * If an allocation fails, the "vend" address is
> * returned. Therefore trigger the overflow path.
> */
> - addr = __alloc_vmap_area(size, align, vstart, vend, node);
> + addr = __alloc_vmap_area(size, align, vstart, vend);
> if (unlikely(addr == vend))
> goto overflow;
>
> --
> 2.11.0
>
Reviewed-by: Roman Gushchin <guro@fb.com>
next prev parent reply other threads:[~2019-05-28 22:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 9:38 [PATCH v3 0/4] Some cleanups for the KVA/vmalloc Uladzislau Rezki (Sony)
2019-05-27 9:38 ` [PATCH v3 1/4] mm/vmap: remove "node" argument Uladzislau Rezki (Sony)
2019-05-28 22:33 ` Roman Gushchin [this message]
2019-05-27 9:38 ` [PATCH v3 2/4] mm/vmap: preload a CPU with one object for split purpose Uladzislau Rezki (Sony)
2019-05-28 22:42 ` Roman Gushchin
2019-05-29 14:27 ` Uladzislau Rezki
2019-05-29 16:34 ` Roman Gushchin
2019-06-03 17:53 ` Uladzislau Rezki
2019-06-03 20:53 ` Uladzislau Rezki
2019-06-03 21:06 ` Roman Gushchin
2019-05-27 9:38 ` [PATCH v3 4/4] mm/vmap: move BUG_ON() check to the unlink_va() Uladzislau Rezki (Sony)
2019-05-27 12:59 ` Steven Rostedt
2019-05-27 14:02 ` Uladzislau Rezki
2019-05-28 22:50 ` Roman Gushchin
2019-05-29 13:58 ` Uladzislau Rezki
2019-05-29 16:26 ` Roman Gushchin
2019-06-03 17:35 ` Uladzislau Rezki
2019-06-03 20:30 ` Roman Gushchin
[not found] ` <20190527093842.10701-4-urezki@gmail.com>
2019-05-28 22:45 ` [PATCH v3 3/4] mm/vmap: get rid of one single unlink_va() when merge Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528223309.GF27847@tower.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=hdanton@sina.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@elte.hu \
--cc=oleksiy.avramchenko@sonymobile.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=tj@kernel.org \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox