From: "Michal Koutný" <mkoutny@suse.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: mkoutny@suse.cz, linux-mm@kvack.org, akpm@linux-foundation.org,
oleg@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: mm: use down_read_killable for locking mmap_sem in access_remote_vm
Date: Thu, 16 May 2019 19:00:35 +0200 [thread overview]
Message-ID: <20190516170034.GO13687@blackbody.suse.cz> (raw)
In-Reply-To: <11ee83c8-5f0f-0950-a588-037bdcf9084e@yandex-team.ru>
On Wed, May 15, 2019 at 11:48:32AM +0300, Konstantin Khlebnikov <khlebnikov@yandex-team.ru> wrote:
> This function ignores any error like reading from unmapped area and
> returns only size of successful transfer. It never returned any error codes.
This is a point I missed. Hence no need to adjust consumers of
__access_remote_vm() (they won't actually handle -EINTR correctly w/out
further changes). This beats my original idea with simplicity.
Reviewed-by: Michal Koutný <mkoutny@suse.com>
Michal
next prev parent reply other threads:[~2019-05-16 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 8:21 [PATCH] " Konstantin Khlebnikov
2019-05-15 8:38 ` Michal Koutný
2019-05-15 8:48 ` Konstantin Khlebnikov
2019-05-16 17:00 ` Michal Koutný [this message]
2019-05-15 11:49 ` Matthew Wilcox
2019-05-15 14:28 ` [PATCH] " Oleg Nesterov
2019-05-17 12:51 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516170034.GO13687@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mkoutny@suse.cz \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox