From: Michal Hocko <mhocko@suse.com>
To: Dexuan Cui <decui@microsoft.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Roman Gushchin <guro@fb.com>, Hugh Dickins <hughd@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Mel Gorman <mgorman@techsingularity.net>,
"dchinner@redhat.com" <dchinner@redhat.com>,
Greg Thelen <gthelen@google.com>,
Kuo-Hsin Yang <vovoy@chromium.org>
Subject: Re: isolate_lru_pages(): kernel BUG at mm/vmscan.c:1689!
Date: Thu, 2 May 2019 08:55:14 -0400 [thread overview]
Message-ID: <20190502125514.GB29835@dhcp22.suse.cz> (raw)
In-Reply-To: <PU1P153MB01693FF5EF3419ACA9A8E1FDBF3B0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
On Wed 01-05-19 23:49:10, Dexuan Cui wrote:
> Hi,
> Today I got the below BUG in isolate_lru_pages() when building the kernel.
>
> My current running kernel, which exhibits the BUG, is based on the mainline kernel's commit
> 262d6a9a63a3 ("Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip").
>
> Looks nobody else reported the issue recently.
>
> So far I only hit the BUG once and I don't know how to reproduce it again, so this is just a FYI.
This is really unexpected. This BUG means that __isolate_lru_page must
have returned EINVAL which implies a non-LRU page on the LRU or an
unevictable page on an evictable LRU list. I am currently travelling so
I cannot have deeper look. There was a similar report which triggered a
different BUG_ON in the reclaim path also stumbling over but that was on
an really old kernel with out of tree patches so it is not clear what
happened there. Do you think it would be possible to setup a crash dump
or apply the following debugging patch in case it reproduces?
diff --git a/mm/vmscan.c b/mm/vmscan.c
index a5ad0b35ab8e..289493986f6c 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1686,6 +1686,7 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan,
continue;
default:
+ dump_page(page);
BUG();
}
}
Thanks for the report.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-05-02 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 23:49 Dexuan Cui
2019-05-02 12:55 ` Michal Hocko [this message]
2019-05-02 18:24 ` Dexuan Cui
2019-05-08 10:33 ` Mel Gorman
2019-05-08 15:44 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502125514.GB29835@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dchinner@redhat.com \
--cc=decui@microsoft.com \
--cc=gthelen@google.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vdavydov.dev@gmail.com \
--cc=vovoy@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox