From: Michal Hocko <mhocko@suse.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yafang Shao <laoar.shao@gmail.com>,
jack@suse.cz, linux-mm@kvack.org, shaoyafang@didiglobal.com
Subject: Re: [PATCH] mm/page-writeback: introduce tracepoint for wait_on_page_writeback
Date: Sun, 28 Apr 2019 23:05:38 +0200 [thread overview]
Message-ID: <20190428210538.GB956@dhcp22.suse.cz> (raw)
In-Reply-To: <20190426112542.bf1cd9fe8e9ed7a659642643@linux-foundation.org>
On Fri 26-04-19 11:25:42, Andrew Morton wrote:
> On Fri, 26 Apr 2019 18:26:42 +0800 Yafang Shao <laoar.shao@gmail.com> wrote:
[...]
> > +/*
> > + * Wait for a page to complete writeback
> > + */
> > +void wait_on_page_writeback(struct page *page)
> > +{
> > + if (PageWriteback(page)) {
> > + trace_wait_on_page_writeback(page, page_mapping(page));
> > + wait_on_page_bit(page, PG_writeback);
> > + }
> > +}
> > +EXPORT_SYMBOL_GPL(wait_on_page_writeback);
>
> But this is a stealth change to the wait_on_page_writeback() licensing.
Why do we have to put that out of line in the first place? Btw.
wait_on_page_bit is EXPORT_SYMBOL...
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-04-28 21:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 10:26 Yafang Shao
2019-04-26 18:25 ` Andrew Morton
2019-04-27 0:31 ` Yafang Shao
2019-04-28 21:05 ` Michal Hocko [this message]
2019-05-11 23:28 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190428210538.GB956@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=shaoyafang@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox