From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com, "Christoph Hellwig" <hch@lst.de>,
"Bob Peterson" <rpeterso@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Dave Chinner" <david@fromorbit.com>,
"Ross Lagerwall" <ross.lagerwall@citrix.com>,
"Mark Syms" <Mark.Syms@citrix.com>,
"Edwin Török" <edvin.torok@citrix.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] iomap: Add a page_prepare callback
Date: Thu, 25 Apr 2019 09:59:33 +0200 [thread overview]
Message-ID: <20190425075933.GA9374@lst.de> (raw)
In-Reply-To: <20190424171804.4305-1-agruenba@redhat.com>
On Wed, Apr 24, 2019 at 07:18:03PM +0200, Andreas Gruenbacher wrote:
> Add a page_prepare calback that's called before a page is written to. This
> will be used by gfs2 to start a transaction in page_prepare and end it in
> page_done. Other filesystems that implement data journaling will require the
> same kind of mechanism.
This looks basically fine to me. But I think it would be nicer to
add a iomap_page_ops structure so that we don't have to add more
pointers directly to the iomap. We can make that struct pointer const
also to avoid runtime overwriting attacks.
next prev parent reply other threads:[~2019-04-25 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 17:18 Andreas Gruenbacher
2019-04-24 17:18 ` [PATCH 2/2] gfs2: Fix iomap write page reclaim deadlock Andreas Gruenbacher
2019-04-25 7:59 ` Christoph Hellwig [this message]
2019-04-25 8:32 ` [PATCH 1/2] iomap: Add a page_prepare callback Jan Kara
2019-04-25 15:03 ` Christoph Hellwig
2019-04-25 15:26 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425075933.GA9374@lst.de \
--to=hch@lst.de \
--cc=Mark.Syms@citrix.com \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=david@fromorbit.com \
--cc=edvin.torok@citrix.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ross.lagerwall@citrix.com \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox