* [PATCH] drm/nouveau: Fix DEVICE_PRIVATE dependencies
@ 2019-04-17 14:26 Yue Haibing
2019-04-17 14:38 ` Jerome Glisse
2019-05-30 15:31 ` Yuehaibing
0 siblings, 2 replies; 4+ messages in thread
From: Yue Haibing @ 2019-04-17 14:26 UTC (permalink / raw)
To: bskeggs, airlied, daniel, jglisse, jgg, rcampbell, leonro, akpm, sfr
Cc: linux-kernel, nouveau, dri-devel, linux-mm, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
During randconfig builds, I occasionally run into an invalid configuration
WARNING: unmet direct dependencies detected for DEVICE_PRIVATE
Depends on [n]: ARCH_HAS_HMM_DEVICE [=n] && ZONE_DEVICE [=n]
Selected by [y]:
- DRM_NOUVEAU_SVM [=y] && HAS_IOMEM [=y] && ARCH_HAS_HMM [=y] && DRM_NOUVEAU [=y] && STAGING [=y]
mm/memory.o: In function `do_swap_page':
memory.c:(.text+0x2754): undefined reference to `device_private_entry_fault'
commit 5da25090ab04 ("mm/hmm: kconfig split HMM address space mirroring from device memory")
split CONFIG_DEVICE_PRIVATE dependencies from
ARCH_HAS_HMM to ARCH_HAS_HMM_DEVICE and ZONE_DEVICE,
so enable DRM_NOUVEAU_SVM will trigger this warning,
cause building failed.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 5da25090ab04 ("mm/hmm: kconfig split HMM address space mirroring from device memory")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/nouveau/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
index 00cd9ab..99e30c1 100644
--- a/drivers/gpu/drm/nouveau/Kconfig
+++ b/drivers/gpu/drm/nouveau/Kconfig
@@ -74,7 +74,8 @@ config DRM_NOUVEAU_BACKLIGHT
config DRM_NOUVEAU_SVM
bool "(EXPERIMENTAL) Enable SVM (Shared Virtual Memory) support"
- depends on ARCH_HAS_HMM
+ depends on ARCH_HAS_HMM_DEVICE
+ depends on ZONE_DEVICE
depends on DRM_NOUVEAU
depends on STAGING
select HMM_MIRROR
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/nouveau: Fix DEVICE_PRIVATE dependencies
2019-04-17 14:26 [PATCH] drm/nouveau: Fix DEVICE_PRIVATE dependencies Yue Haibing
@ 2019-04-17 14:38 ` Jerome Glisse
2019-05-30 15:31 ` Yuehaibing
1 sibling, 0 replies; 4+ messages in thread
From: Jerome Glisse @ 2019-04-17 14:38 UTC (permalink / raw)
To: Yue Haibing
Cc: bskeggs, airlied, daniel, jgg, rcampbell, leonro, akpm, sfr,
linux-kernel, nouveau, dri-devel, linux-mm
On Wed, Apr 17, 2019 at 10:26:32PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> During randconfig builds, I occasionally run into an invalid configuration
>
> WARNING: unmet direct dependencies detected for DEVICE_PRIVATE
> Depends on [n]: ARCH_HAS_HMM_DEVICE [=n] && ZONE_DEVICE [=n]
> Selected by [y]:
> - DRM_NOUVEAU_SVM [=y] && HAS_IOMEM [=y] && ARCH_HAS_HMM [=y] && DRM_NOUVEAU [=y] && STAGING [=y]
>
> mm/memory.o: In function `do_swap_page':
> memory.c:(.text+0x2754): undefined reference to `device_private_entry_fault'
>
> commit 5da25090ab04 ("mm/hmm: kconfig split HMM address space mirroring from device memory")
> split CONFIG_DEVICE_PRIVATE dependencies from
> ARCH_HAS_HMM to ARCH_HAS_HMM_DEVICE and ZONE_DEVICE,
> so enable DRM_NOUVEAU_SVM will trigger this warning,
> cause building failed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 5da25090ab04 ("mm/hmm: kconfig split HMM address space mirroring from device memory")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
> ---
> drivers/gpu/drm/nouveau/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
> index 00cd9ab..99e30c1 100644
> --- a/drivers/gpu/drm/nouveau/Kconfig
> +++ b/drivers/gpu/drm/nouveau/Kconfig
> @@ -74,7 +74,8 @@ config DRM_NOUVEAU_BACKLIGHT
>
> config DRM_NOUVEAU_SVM
> bool "(EXPERIMENTAL) Enable SVM (Shared Virtual Memory) support"
> - depends on ARCH_HAS_HMM
> + depends on ARCH_HAS_HMM_DEVICE
> + depends on ZONE_DEVICE
> depends on DRM_NOUVEAU
> depends on STAGING
> select HMM_MIRROR
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/nouveau: Fix DEVICE_PRIVATE dependencies
2019-04-17 14:26 [PATCH] drm/nouveau: Fix DEVICE_PRIVATE dependencies Yue Haibing
2019-04-17 14:38 ` Jerome Glisse
@ 2019-05-30 15:31 ` Yuehaibing
2019-05-30 15:49 ` Jason Gunthorpe
1 sibling, 1 reply; 4+ messages in thread
From: Yuehaibing @ 2019-05-30 15:31 UTC (permalink / raw)
To: bskeggs, airlied, daniel, jglisse, jgg, rcampbell, leonro, akpm,
sfr, gregkh, b.zolnierkie
Cc: linux-kernel, nouveau, dri-devel, linux-mm
Hi all,
Friendly ping:
Who can take this?
On 2019/4/17 22:26, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> During randconfig builds, I occasionally run into an invalid configuration
>
> WARNING: unmet direct dependencies detected for DEVICE_PRIVATE
> Depends on [n]: ARCH_HAS_HMM_DEVICE [=n] && ZONE_DEVICE [=n]
> Selected by [y]:
> - DRM_NOUVEAU_SVM [=y] && HAS_IOMEM [=y] && ARCH_HAS_HMM [=y] && DRM_NOUVEAU [=y] && STAGING [=y]
>
> mm/memory.o: In function `do_swap_page':
> memory.c:(.text+0x2754): undefined reference to `device_private_entry_fault'
>
> commit 5da25090ab04 ("mm/hmm: kconfig split HMM address space mirroring from device memory")
> split CONFIG_DEVICE_PRIVATE dependencies from
> ARCH_HAS_HMM to ARCH_HAS_HMM_DEVICE and ZONE_DEVICE,
> so enable DRM_NOUVEAU_SVM will trigger this warning,
> cause building failed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 5da25090ab04 ("mm/hmm: kconfig split HMM address space mirroring from device memory")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/nouveau/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
> index 00cd9ab..99e30c1 100644
> --- a/drivers/gpu/drm/nouveau/Kconfig
> +++ b/drivers/gpu/drm/nouveau/Kconfig
> @@ -74,7 +74,8 @@ config DRM_NOUVEAU_BACKLIGHT
>
> config DRM_NOUVEAU_SVM
> bool "(EXPERIMENTAL) Enable SVM (Shared Virtual Memory) support"
> - depends on ARCH_HAS_HMM
> + depends on ARCH_HAS_HMM_DEVICE
> + depends on ZONE_DEVICE
> depends on DRM_NOUVEAU
> depends on STAGING
> select HMM_MIRROR
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/nouveau: Fix DEVICE_PRIVATE dependencies
2019-05-30 15:31 ` Yuehaibing
@ 2019-05-30 15:49 ` Jason Gunthorpe
0 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2019-05-30 15:49 UTC (permalink / raw)
To: Yuehaibing, Jérôme Glisse
Cc: bskeggs, airlied, daniel, jglisse, rcampbell, Leon Romanovsky,
akpm, sfr, gregkh, b.zolnierkie, linux-kernel, nouveau,
dri-devel, linux-mm
On Thu, May 30, 2019 at 11:31:12PM +0800, Yuehaibing wrote:
> Hi all,
>
> Friendly ping:
>
> Who can take this?
>
> On 2019/4/17 22:26, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@huawei.com>
> >
> > During randconfig builds, I occasionally run into an invalid configuration
> >
> > WARNING: unmet direct dependencies detected for DEVICE_PRIVATE
> > Depends on [n]: ARCH_HAS_HMM_DEVICE [=n] && ZONE_DEVICE [=n]
> > Selected by [y]:
> > - DRM_NOUVEAU_SVM [=y] && HAS_IOMEM [=y] && ARCH_HAS_HMM [=y] && DRM_NOUVEAU [=y] && STAGING [=y]
> >
> > mm/memory.o: In function `do_swap_page':
> > memory.c:(.text+0x2754): undefined reference to `device_private_entry_fault'
> >
> > commit 5da25090ab04 ("mm/hmm: kconfig split HMM address space mirroring from device memory")
> > split CONFIG_DEVICE_PRIVATE dependencies from
> > ARCH_HAS_HMM to ARCH_HAS_HMM_DEVICE and ZONE_DEVICE,
> > so enable DRM_NOUVEAU_SVM will trigger this warning,
> > cause building failed.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Fixes: 5da25090ab04 ("mm/hmm: kconfig split HMM address space mirroring from device memory")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > drivers/gpu/drm/nouveau/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
> > index 00cd9ab..99e30c1 100644
> > +++ b/drivers/gpu/drm/nouveau/Kconfig
> > @@ -74,7 +74,8 @@ config DRM_NOUVEAU_BACKLIGHT
> >
> > config DRM_NOUVEAU_SVM
> > bool "(EXPERIMENTAL) Enable SVM (Shared Virtual Memory) support"
> > - depends on ARCH_HAS_HMM
> > + depends on ARCH_HAS_HMM_DEVICE
> > + depends on ZONE_DEVICE
> > depends on DRM_NOUVEAU
> > depends on STAGING
> > select HMM_MIRROR
> >
I'm expecting to take a patch like this into the new hmm git tree once
Jerome sends his Final Solution for the kconfig problems.
Maybe it is this patch, Jerome??
Regards,
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-30 15:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 14:26 [PATCH] drm/nouveau: Fix DEVICE_PRIVATE dependencies Yue Haibing
2019-04-17 14:38 ` Jerome Glisse
2019-05-30 15:31 ` Yuehaibing
2019-05-30 15:49 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox