From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org,
dave@stgolabs.net, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Simplify shrink_inactive_list()
Date: Thu, 11 Apr 2019 18:13:10 -0400 [thread overview]
Message-ID: <20190411221310.sz5jtsb563wlaj3v@ca-dmjordan1.us.oracle.com> (raw)
In-Reply-To: <155490878845.17489.11907324308110282086.stgit@localhost.localdomain>
On Wed, Apr 10, 2019 at 06:07:04PM +0300, Kirill Tkhai wrote:
> @@ -1934,17 +1935,10 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec,
> __mod_node_page_state(pgdat, NR_ISOLATED_ANON + file, nr_taken);
> reclaim_stat->recent_scanned[file] += nr_taken;
>
> - if (current_is_kswapd()) {
> - if (global_reclaim(sc))
> - __count_vm_events(PGSCAN_KSWAPD, nr_scanned);
> - count_memcg_events(lruvec_memcg(lruvec), PGSCAN_KSWAPD,
> - nr_scanned);
> - } else {
> - if (global_reclaim(sc))
> - __count_vm_events(PGSCAN_DIRECT, nr_scanned);
> - count_memcg_events(lruvec_memcg(lruvec), PGSCAN_DIRECT,
> - nr_scanned);
> - }
> + if (global_reclaim(sc))
> + __count_vm_events(PGSCAN_KSWAPD + is_direct, nr_scanned);
> + __count_memcg_events(lruvec_memcg(lruvec), PGSCAN_KSWAPD + is_direct,
> + nr_scanned);
Nice to avoid duplication like this, but now it takes looking at
vm_event_item.h to understand that (PGSCAN_KSWAPD + is_direct) might mean
PGSCAN_DIRECT.
What about this pattern for each block instead, which makes the stat used
explicit and avoids the header change?
stat = current_is_kswapd() ? PG*_KSWAPD : PG*_DIRECT;
next prev parent reply other threads:[~2019-04-11 22:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 15:07 Kirill Tkhai
2019-04-11 22:13 ` Daniel Jordan [this message]
2019-04-12 0:05 ` Baoquan He
2019-04-12 10:52 ` Kirill Tkhai
2019-04-12 10:55 ` [PATCH v2] " Kirill Tkhai
2019-04-12 11:31 ` Michal Hocko
2019-04-12 11:33 ` Kirill Tkhai
2019-04-12 12:05 ` Michal Hocko
2019-04-12 12:10 ` [PATCH v3] " Kirill Tkhai
2019-04-12 14:16 ` Daniel Jordan
2019-04-12 15:16 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411221310.sz5jtsb563wlaj3v@ca-dmjordan1.us.oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=hannes@cmpxchg.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox