From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB585C4360F for ; Thu, 28 Mar 2019 15:21:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 864442173C for ; Thu, 28 Mar 2019 15:21:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 864442173C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 239086B0003; Thu, 28 Mar 2019 11:21:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BEFF6B0006; Thu, 28 Mar 2019 11:21:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 087BE6B0007; Thu, 28 Mar 2019 11:21:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by kanga.kvack.org (Postfix) with ESMTP id A5F1D6B0003 for ; Thu, 28 Mar 2019 11:21:56 -0400 (EDT) Received: by mail-ed1-f71.google.com with SMTP id j3so5188323edb.14 for ; Thu, 28 Mar 2019 08:21:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; bh=USUSqjQ6FderEbZp7maDQHWFPSjdmf25jjTSu6CW2hc=; b=dydNuofD6NLQTkMYmfi4RBnCxk9ZWoBTx85OdOOXy7F2y654DEGANVqC8er7m5O2IJ uHR57fE+lLmlHmIaiNuHH7zBNs2W/GRWtmS2clbv6fBersa7ZJV35NEGALzgOiNiin4K pOazYfPYtkD2BymEZsHrE+PurtP1pr8g7QhaiUg87bbEt/uN8Bv2RGd6vvVGw2RyCaYp BKxtqMmMUpWv6PmpmfazusUAUxFjXH94Y8zHOSWLVbLnC7RKHBvNLhwgkSND4HJG7Kwk u94ZWPcstV2u6rM0T4BWfkob7kal7lX+03elD2GESzKW2/J+PDqDUZ++eeQnDCkI4zz3 iZ2g== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of steven.price@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=steven.price@arm.com X-Gm-Message-State: APjAAAX7FUrzxsDIA35G5lQuzy8tiUdokWJLtIcu31fugbJgiRiC64dV R4/fbPRxAJ9TszThbewuXFZLfi+jSbSG3Vk6hkK1bL1S2zdtnLAyQi1X7Sl4ff5pXC6eX6p24AO GEdu/EOXfo3ULeGETHPeonekcoJwYjwD2q9PMgUK3wz8bQEoZLB55rQFzQlav7LlaFw== X-Received: by 2002:a50:eac9:: with SMTP id u9mr18337418edp.159.1553786516142; Thu, 28 Mar 2019 08:21:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqylN9sHCFS18lMS1Ap9x8R+hUwxPa8oKmYYaHDNA0hHk4/9sWG0kImdtJRJ/5cyr+/cNWC7 X-Received: by 2002:a50:eac9:: with SMTP id u9mr18337336edp.159.1553786514710; Thu, 28 Mar 2019 08:21:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553786514; cv=none; d=google.com; s=arc-20160816; b=mey6KFzC1XUqGPagDBlcncACHxP2Bl/N1bWk8Na0fKrH6DhM4T0jrYIzoy8+Jg5HGu orSnXCgD+c6ITN7MCMcL6ulbzVs/6ck0VJnaQoZWO0S5+5Ze7X13FrJ4qdTQwsaBdlfS MW9sh2X5qH5EC4XsnDFXAz7h4jPtaOmgkyGN3QJ++n6GDyRB9va6VV2Z30xQdfdL8ARp TkG018CYU0hM/3F6558iVAjZcH6FM7QTEbiW8M2z0fCoqbAK48nCuVPzOBalU/Gfb19H r3WhWko1HJFnT9+J4J4S2SN/Iph5xAXThrCnVHdWJ3qBiUq8JuVIh4vNlTkBp+yyiYbo 3cGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=USUSqjQ6FderEbZp7maDQHWFPSjdmf25jjTSu6CW2hc=; b=FVLcD9Duu2LIsynfAAf3BLHT3G0HrqwTABI7X5+p5L19Mrpw6jyXz6+Y+D/nP6mzEv ukblA5m/DRsnufKlwt6i1yLK/xVdbt8YHba/sE3EjUOTaQr7i2vzpaPvSdt+cCMFEqmw 5hblBwz+jqweauA7OzQKI35GJudYUbfZ2M83kK9RLk5r7EWyF+DRTHWYb1pJGAl6jQ70 wqD1eeLxeJFDnlBF68GLBDcuOLR6hLHfP1hnKwwdmNqkF05SgZfvgUXiZ9FdYgp15LDv y53jgQKAABIZljjXa9NorWSV1qfuYL4mt3PclFthkEVkv0yhwOWb1ZEUm0GNekCct9Ff qVEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of steven.price@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=steven.price@arm.com Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id s13si4880584edb.330.2019.03.28.08.21.54 for ; Thu, 28 Mar 2019 08:21:54 -0700 (PDT) Received-SPF: pass (google.com: domain of steven.price@arm.com designates 217.140.101.70 as permitted sender) client-ip=217.140.101.70; Authentication-Results: mx.google.com; spf=pass (google.com: domain of steven.price@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=steven.price@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E88C15AB; Thu, 28 Mar 2019 08:21:53 -0700 (PDT) Received: from e112269-lin.arm.com (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35CD93F557; Thu, 28 Mar 2019 08:21:50 -0700 (PDT) From: Steven Price To: linux-mm@kvack.org Cc: Steven Price , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Dave Hansen , Ingo Molnar , James Morse , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Peter Zijlstra , Thomas Gleixner , Will Deacon , x86@kernel.org, "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Rutland , "Liang, Kan" Subject: [PATCH v7 00/20] Convert x86 & arm64 to use generic page walk Date: Thu, 28 Mar 2019 15:20:44 +0000 Message-Id: <20190328152104.23106-1-steven.price@arm.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Most architectures current have a debugfs file for dumping the kernel page tables. Currently each architecture has to implement custom functions for walking the page tables because the generic walk_page_range() function is unable to walk the page tables used by the kernel. This series extends the capabilities of walk_page_range() so that it can deal with the page tables of the kernel (which have no VMAs and can contain larger huge pages than exist for user space). x86 and arm64 are then converted to make use of walk_page_range() removing the custom page table walkers. To enable a generic page table walker to walk the unusual mappings of the kernel we need to implement a set of functions which let us know when the walker has reached the leaf entry. Since arm, powerpc, s390, sparc and x86 all have p?d_large macros lets standardise on that and implement those that are missing. Potentially future changes could unify the implementations of the debugfs walkers further, moving the common functionality into common code. This would require a common way of handling the effective permissions (currently implemented only for x86) along with a per-arch way of formatting the page table information for debugfs. One immediate benefit would be getting the KASAN speed up optimisation in arm64 (and other arches) which is currently only implemented for x86. Also available as a git tree: git://linux-arm.org/linux-sp.git walk_page_range/v7 Changes since v6: * Split the changes for powerpc. pmd_large() is now added in patch 4 patch, and pmd_is_leaf() removed in patch 5. Changes since v5: * Updated comment for struct mm_walk based on Mike Rapoport's suggestion Changes since v4: * Correctly force result to a boolean in p?d_large for powerpc. * Added Acked-bys * Rebased onto v5.1-rc1 Changes since v3: * Restored the generic macros, only implement p?d_large() for architectures that have support for large pages. This also means adding dummy #defines for architectures that define p?d_large as static inline to avoid picking up the generic macro. * Drop the 'depth' argument from pte_hole * Because we no longer have the depth for holes, we also drop support in x86 for showing missing pages in debugfs. See discussion below: https://lore.kernel.org/lkml/26df02dd-c54e-ea91-bdd1-0a4aad3a30ac@arm.com/ * mips: only define p?d_large when _PAGE_HUGE is defined. Changes since v2: * Rather than attemping to provide generic macros, actually implement p?d_large() for each architecture. Changes since v1: * Added p4d_large() macro * Comments to explain p?d_large() macro semantics * Expanded comment for pte_hole() callback to explain mapping between depth and P?D * Handle folded page tables at all levels, so depth from pte_hole() ignores folding at any level (see real_depth() function in mm/pagewalk.c) Steven Price (20): arc: mm: Add p?d_large() definitions arm64: mm: Add p?d_large() definitions mips: mm: Add p?d_large() definitions powerpc: mm: Add p?d_large() definitions KVM: PPC: Book3S HV: Remove pmd_is_leaf() riscv: mm: Add p?d_large() definitions s390: mm: Add p?d_large() definitions sparc: mm: Add p?d_large() definitions x86: mm: Add p?d_large() definitions mm: Add generic p?d_large() macros mm: pagewalk: Add p4d_entry() and pgd_entry() mm: pagewalk: Allow walking without vma mm: pagewalk: Add test_p?d callbacks arm64: mm: Convert mm/dump.c to use walk_page_range() x86: mm: Don't display pages which aren't present in debugfs x86: mm: Point to struct seq_file from struct pg_state x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct x86: mm: Convert ptdump_walk_pgd_level_core() to take an mm_struct x86: mm: Convert dump_pagetables to use walk_page_range arch/arc/include/asm/pgtable.h | 1 + arch/arm64/include/asm/pgtable.h | 2 + arch/arm64/mm/dump.c | 117 +++---- arch/mips/include/asm/pgtable-64.h | 8 + arch/powerpc/include/asm/book3s/64/pgtable.h | 30 +- arch/powerpc/kvm/book3s_64_mmu_radix.c | 12 +- arch/riscv/include/asm/pgtable-64.h | 7 + arch/riscv/include/asm/pgtable.h | 7 + arch/s390/include/asm/pgtable.h | 2 + arch/sparc/include/asm/pgtable_64.h | 2 + arch/x86/include/asm/pgtable.h | 10 +- arch/x86/mm/debug_pagetables.c | 8 +- arch/x86/mm/dump_pagetables.c | 347 ++++++++++--------- arch/x86/platform/efi/efi_32.c | 2 +- arch/x86/platform/efi/efi_64.c | 4 +- include/asm-generic/pgtable.h | 19 + include/linux/mm.h | 26 +- mm/pagewalk.c | 76 +++- 18 files changed, 407 insertions(+), 273 deletions(-) -- 2.20.1