linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: vdavydov.dev@gmail.com, bigeasy@linutronix.de,
	adobriyan@gmail.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm/list_lru: Simplify __list_lru_walk_one()
Date: Wed, 20 Mar 2019 11:52:51 -0700	[thread overview]
Message-ID: <20190320115251.026f65e83ebde2b8ebf51134@linux-foundation.org> (raw)
In-Reply-To: <155308075272.10600.3895589023886665456.stgit@localhost.localdomain>

On Wed, 20 Mar 2019 14:19:27 +0300 Kirill Tkhai <ktkhai@virtuozzo.com> wrote:

> 1)Spinlock must be locked in any case, so assert_spin_locked()
>   are moved above the switch;

This isn't true.  When the ->isolate() handler xfs_buftarg_wait_rele()
(at least) returns LRU_SKIP, the lock is not held.


  reply	other threads:[~2019-03-20 18:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 11:19 Kirill Tkhai
2019-03-20 18:52 ` Andrew Morton [this message]
2019-03-20 19:52   ` Kirill Tkhai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190320115251.026f65e83ebde2b8ebf51134@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=adobriyan@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=ktkhai@virtuozzo.com \
    --cc=linux-mm@kvack.org \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox