From: Matthew Wilcox <willy@infradead.org>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
pasha.tatashin@oracle.com, mhocko@suse.com,
rppt@linux.vnet.ibm.com, richard.weiyang@gmail.com,
linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment
Date: Wed, 20 Mar 2019 04:19:59 -0700 [thread overview]
Message-ID: <20190320111959.GV19508@bombadil.infradead.org> (raw)
In-Reply-To: <20190320073540.12866-1-bhe@redhat.com>
On Wed, Mar 20, 2019 at 03:35:38PM +0800, Baoquan He wrote:
> /*
> - * returns the number of sections whose mem_maps were properly
> - * set. If this is <=0, then that means that the passed-in
> - * map was not consumed and must be freed.
> + * sparse_add_one_section - add a memory section
> + * @nid: The node to add section on
> + * @start_pfn: start pfn of the memory range
> + * @altmap: device page map
> + *
> + * Return 0 on success and an appropriate error code otherwise.
> */
I think it's worth documenting what those error codes are. Seems to be
just -ENOMEM and -EEXIST, but it'd be nice for users to know what they
can expect under which circumstances.
Also, -EEXIST is a bad errno to return here:
$ errno EEXIST
EEXIST 17 File exists
What file? I think we should be using -EBUSY instead in case this errno
makes it back to userspace:
$ errno EBUSY
EBUSY 16 Device or resource busy
next prev parent reply other threads:[~2019-03-20 11:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 7:35 Baoquan He
2019-03-20 7:35 ` [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section() Baoquan He
2019-03-20 7:56 ` Mike Rapoport
2019-03-20 8:03 ` Baoquan He
2019-03-20 10:13 ` Baoquan He
2019-03-20 11:22 ` Matthew Wilcox
2019-03-20 11:27 ` Mike Rapoport
2019-03-20 7:35 ` [PATCH 3/3] mm/sparse: Rename function related to section memmap allocation/free Baoquan He
2019-03-20 7:50 ` [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Mike Rapoport
2019-03-20 8:00 ` Baoquan He
2019-03-20 11:19 ` Matthew Wilcox [this message]
2019-03-20 11:53 ` Baoquan He
2019-03-20 12:20 ` Oscar Salvador
2019-03-20 12:22 ` Matthew Wilcox
2019-03-20 12:36 ` Mike Rapoport
2019-03-20 12:58 ` Matthew Wilcox
2019-03-21 6:40 ` Baoquan He
2019-03-21 9:21 ` Baoquan He
2019-03-21 10:24 ` William Kucharski
2019-03-21 10:35 ` Michal Hocko
2019-03-21 11:19 ` William Kucharski
2019-03-21 14:19 ` Baoquan He
2019-03-20 12:37 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320111959.GV19508@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox