From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Suren Baghdasaryan <surenb@google.com>
Cc: gregkh@linuxfoundation.org, tj@kernel.org, lizefan@huawei.com,
hannes@cmpxchg.org, axboe@kernel.dk, dennis@kernel.org,
dennisszhou@gmail.com, mingo@redhat.com, peterz@infradead.org,
akpm@linux-foundation.org, corbet@lwn.net,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v6 1/7] psi: introduce state_mask to represent stalled psi states
Date: Wed, 20 Mar 2019 11:02:49 +1100 [thread overview]
Message-ID: <20190320110249.652ec153@canb.auug.org.au> (raw)
In-Reply-To: <20190319235619.260832-2-surenb@google.com>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
Hi Suren,
On Tue, 19 Mar 2019 16:56:13 -0700 Suren Baghdasaryan <surenb@google.com> wrote:
>
> The psi monitoring patches will need to determine the same states as
> record_times(). To avoid calculating them twice, maintain a state mask
> that can be consulted cheaply. Do this in a separate patch to keep the
> churn in the main feature patch at a minimum.
>
> This adds 4-byte state_mask member into psi_group_cpu struct which results
> in its first cacheline-aligned part becoming 52 bytes long. Add explicit
> values to enumeration element counters that affect psi_group_cpu struct
> size.
>
> Link: http://lkml.kernel.org/r/20190124211518.244221-4-surenb@google.com
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Dennis Zhou <dennis@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
This last SOB line should not be here ... it is only there on the
original patch because I import Andrew's quilt series into linux-next.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-20 0:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 23:56 [PATCH v6 0/7] psi: pressure stall monitors v6 Suren Baghdasaryan
2019-03-19 23:56 ` [PATCH v6 1/7] psi: introduce state_mask to represent stalled psi states Suren Baghdasaryan
2019-03-20 0:02 ` Stephen Rothwell [this message]
2019-03-20 0:06 ` Suren Baghdasaryan
2019-03-20 0:15 ` Stephen Rothwell
2019-03-20 1:53 ` Suren Baghdasaryan
2019-03-19 23:56 ` [PATCH v6 2/7] psi: make psi_enable static Suren Baghdasaryan
2019-03-20 20:55 ` Johannes Weiner
2019-03-19 23:56 ` [PATCH v6 3/7] psi: rename psi fields in preparation for psi trigger addition Suren Baghdasaryan
2019-03-20 20:57 ` Johannes Weiner
2019-03-19 23:56 ` [PATCH v6 4/7] psi: split update_stats into parts Suren Baghdasaryan
2019-03-20 20:59 ` Johannes Weiner
2019-03-19 23:56 ` [PATCH v6 5/7] psi: track changed states Suren Baghdasaryan
2019-03-20 21:01 ` Johannes Weiner
2019-03-19 23:56 ` [PATCH v6 6/7] refactor header includes to allow kthread.h inclusion in psi_types.h Suren Baghdasaryan
2019-03-20 21:04 ` Johannes Weiner
2019-03-19 23:56 ` [PATCH v6 7/7] psi: introduce psi monitor Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320110249.652ec153@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dennis@kernel.org \
--cc=dennisszhou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=surenb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox