From: Oscar Salvador <osalvador@suse.de>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Yang Shi <shy828301@gmail.com>, Cyril Hrubis <chrubis@suse.cz>,
Linux MM <linux-mm@kvack.org>,
linux-api@vger.kernel.org, ltp@lists.linux.it,
Vlastimil Babka <vbabka@suse.cz>,
kirill.shutemov@linux.intel.com
Subject: Re: mbind() fails to fail with EIO
Date: Tue, 19 Mar 2019 16:10:50 +0100 [thread overview]
Message-ID: <20190319151050.7ym3kdmhec7bf2ky@d104.suse.de> (raw)
In-Reply-To: <20190319145233.rcfa6bvx6xyv64l3@kshutemo-mobl1>
On Tue, Mar 19, 2019 at 05:52:33PM +0300, Kirill A. Shutemov wrote:
> On Tue, Mar 19, 2019 at 03:41:33PM +0100, Oscar Salvador wrote:
> > On Tue, Mar 19, 2019 at 05:26:39PM +0300, Kirill A. Shutemov wrote:
> > > That's all sounds reasonable.
> > >
> > > We only need to make sure the bug fixed by 77bf45e78050 will not be
> > > re-introduced.
> >
> > I gave it a spin with the below patch.
> > Your testcase works (so the bug is not re-introduced), and we get -EIO
> > when running the ltp test [1].
> > So unless I am missing something, it should be enough.
>
> Don't we need to bypass !vma_migratable(vma) check in
> queue_pages_test_walk() for MPOL_MF_STRICT? I mean user still might want
> to check if all pages are on the right not even the vma is not migratable.
Yeah, I missed that.
Then, I guess that we have to put the check into queue_pages_pte_range as well,
and place it right before migrate_page_add().
So, if it is not placed in the node and is not migreatable, we return -EIO.
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2019-03-19 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 16:01 Cyril Hrubis
2019-03-18 16:08 ` Qian Cai
2019-03-19 12:59 ` Cyril Hrubis
2019-03-18 18:12 ` Yang Shi
2019-03-19 13:27 ` Oscar Salvador
2019-03-19 14:26 ` Kirill A. Shutemov
2019-03-19 14:30 ` Cyril Hrubis
2019-03-19 14:41 ` Oscar Salvador
2019-03-19 14:52 ` Kirill A. Shutemov
2019-03-19 15:10 ` Oscar Salvador [this message]
2019-03-19 16:29 ` Yang Shi
2019-03-19 16:25 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319151050.7ym3kdmhec7bf2ky@d104.suse.de \
--to=osalvador@suse.de \
--cc=chrubis@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ltp@lists.linux.it \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox