From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B900C43381 for ; Thu, 14 Mar 2019 06:33:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C035B217F5 for ; Thu, 14 Mar 2019 06:33:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C035B217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3DEA08E0003; Thu, 14 Mar 2019 02:33:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 366838E0001; Thu, 14 Mar 2019 02:33:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 209268E0003; Thu, 14 Mar 2019 02:33:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by kanga.kvack.org (Postfix) with ESMTP id B88248E0001 for ; Thu, 14 Mar 2019 02:33:41 -0400 (EDT) Received: by mail-ed1-f72.google.com with SMTP id k6so1962433edq.3 for ; Wed, 13 Mar 2019 23:33:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:references:mime-version:content-disposition :in-reply-to:user-agent; bh=Qe9VFjC4IRHNa/xDlUnLdZ94eHMt/k16Oh+sKcVA+KI=; b=Pn1HimrlVaMo+zqCpBMRmhbaTrieYTkFjgColXC4rcX+4MkqvgllDC9XMdi0xv2Jc6 GUfWeWC5NCzlRuIiiWjXwXOVdS+tNXzGBlQXDaEvCxg8ytz6ziD6jsoyYuzGFHzzDfzC +TCuYKBlu/cnad7S9ESSyjkexjUpnQs9YOq8PLKKjCEqlRl5UdB3tCgm0YJ32GJ9WN5b NTv6IPaIF9ID0ygDCZkJ/jVkf3q7WgNl0nHXd1Oom5a/7vkuTDNuHpiKSUZreRlM29VE zjG7rz3uA60P6k1nG72alljPwjhqlANzBh0TRRantx3FVqWePMYVlcSH5o+890LtO2zP vuig== X-Original-Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Gm-Message-State: APjAAAX2mXFk+1qOqTY+nd7do2ZT8EnEAL0vIHhk22nT34XDpPcbsjpA ur5hMGpeUMr++6BBLt4ckFwUiQhJIluO4mlo/s1M77X7nIVFoT2AvlVA6WfAAO6bsAB9AV1PdMz uTllkNdqtRLHMdzvVzy0Dvzk1h1EaPxEER4wD0lIg1vxrfmSKbs8DXebNCT7IAkk= X-Received: by 2002:a50:d94f:: with SMTP id u15mr9884265edj.256.1552545221266; Wed, 13 Mar 2019 23:33:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqwWClvbeb78sTdyLiSUxrBMJW2kd/eIwyatwmh85M852/FOnYe1+nZsNagzxLNBl2XgM88c X-Received: by 2002:a50:d94f:: with SMTP id u15mr9884226edj.256.1552545220422; Wed, 13 Mar 2019 23:33:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552545220; cv=none; d=google.com; s=arc-20160816; b=h9e9w++LpFlQmQZIwb5oPjfmI7IZnuVbHNkdX6EZnMklkQLA+htRwiO60AqGhtCBCB iOJrh+So7yiLQEG2M0zGPo0q2o1x27zD3fR1F5Tmhqlxfq8RdUOa82p4wws2KL4a/zPy uhB2otxdyLy86f5MJd9EgDVvd1PkF/VTLo95Cb5NAm07ugApf4YrTTzwVv6tymf1fnTY 29pDC83K6AeIaGoL0LwUCjmNsAgF32Zo+FDICbAm6H3b0AGlp8Cat26sga45Xfkxq3oZ Kd7LdAxncVEbEfrGgzR8UmRgA2GQOblpWDo3E6DHHYXGWYZMhAoL/SmNyeai9QITpxnQ qp4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date; bh=Qe9VFjC4IRHNa/xDlUnLdZ94eHMt/k16Oh+sKcVA+KI=; b=ZOtH2lWljfHohfrs5OB9xgOVk3+kjZeTpD4DSDg4CsjaozIp6Wd9NVxshoNDm9YbSO awNvfWZqr8xLZgGdPXjXr4T+cJpEKQ9Fdr6oImjl21BfK5PG8IqmdgRlDlgJ94OXcw6J sjGNs2eGwHLblb0tOntuk0AJXIF5jGph5doThJatBR/pmlWTd5EBXGO0lIQ7lwmvvW0c BrmpskR7bl8uZh+THjb7Tz1r51rKWShR0UzqPA4no8Y2RkxdGbYaXd++ZFIrxwpcRMPc UYtH894VyR99/PwOjr6W397QgbKvXfYEm9s8NuPMWetTXd5OJcYNxNzclOSMycc3JjJA TPXA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id t15si346788edc.157.2019.03.13.23.33.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 23:33:40 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) client-ip=195.135.220.15; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning mhocko@kernel.org does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=mhocko@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E335BAD84; Thu, 14 Mar 2019 06:33:39 +0000 (UTC) Date: Thu, 14 Mar 2019 07:33:38 +0100 From: Michal Hocko To: Qian Cai Cc: akpm@linux-foundation.org, osalvador@suse.de, anshuman.khandual@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hotplug: fix notification in offline error path Message-ID: <20190314063338.GB7473@dhcp22.suse.cz> References: <20190313210939.49628-1-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190313210939.49628-1-cai@lca.pw> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 13-03-19 17:09:39, Qian Cai wrote: > When start_isolate_page_range() returned -EBUSY in __offline_pages(), it > calls memory_notify(MEM_CANCEL_OFFLINE, &arg) with an uninitialized > "arg". As the result, it triggers warnings below. Also, it is only > necessary to notify MEM_CANCEL_OFFLINE after MEM_GOING_OFFLINE. > > page:ffffea0001200000 count:1 mapcount:0 mapping:0000000000000000 > index:0x0 > flags: 0x3fffe000001000(reserved) > raw: 003fffe000001000 ffffea0001200008 ffffea0001200008 0000000000000000 > raw: 0000000000000000 0000000000000000 00000001ffffffff 0000000000000000 > page dumped because: unmovable page > WARNING: CPU: 25 PID: 1665 at mm/kasan/common.c:665 > kasan_mem_notifier+0x34/0x23b > CPU: 25 PID: 1665 Comm: bash Tainted: G W 5.0.0+ #94 > Hardware name: HP ProLiant DL180 Gen9/ProLiant DL180 Gen9, BIOS U20 > 10/25/2017 > RIP: 0010:kasan_mem_notifier+0x34/0x23b > RSP: 0018:ffff8883ec737890 EFLAGS: 00010206 > RAX: 0000000000000246 RBX: ff10f0f4435f1000 RCX: f887a7a21af88000 > RDX: dffffc0000000000 RSI: 0000000000000020 RDI: ffff8881f221af88 > RBP: ffff8883ec737898 R08: ffff888000000000 R09: ffffffffb0bddcd0 > R10: ffffed103e857088 R11: ffff8881f42b8443 R12: dffffc0000000000 > R13: 00000000fffffff9 R14: dffffc0000000000 R15: 0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000560fbd31d730 CR3: 00000004049c6003 CR4: 00000000001606a0 > Call Trace: > notifier_call_chain+0xbf/0x130 > __blocking_notifier_call_chain+0x76/0xc0 > blocking_notifier_call_chain+0x16/0x20 > memory_notify+0x1b/0x20 > __offline_pages+0x3e2/0x1210 > offline_pages+0x11/0x20 > memory_block_action+0x144/0x300 > memory_subsys_offline+0xe5/0x170 > device_offline+0x13f/0x1e0 > state_store+0xeb/0x110 > dev_attr_store+0x3f/0x70 > sysfs_kf_write+0x104/0x150 > kernfs_fop_write+0x25c/0x410 > __vfs_write+0x66/0x120 > vfs_write+0x15a/0x4f0 > ksys_write+0xd2/0x1b0 > __x64_sys_write+0x73/0xb0 > do_syscall_64+0xeb/0xb78 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > RIP: 0033:0x7f14f75cc3b8 > RSP: 002b:00007ffe84d01d68 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 > RAX: ffffffffffffffda RBX: 0000000000000008 RCX: 00007f14f75cc3b8 > RDX: 0000000000000008 RSI: 0000563f8e433d70 RDI: 0000000000000001 > RBP: 0000563f8e433d70 R08: 000000000000000a R09: 00007ffe84d018f0 > R10: 000000000000000a R11: 0000000000000246 R12: 00007f14f789e780 > R13: 0000000000000008 R14: 00007f14f7899740 R15: 0000000000000008 > > Fixes: 7960509329c2 ("mm, memory_hotplug: print reason for the offlining failure") Cc: stable # 5.0 > Signed-off-by: Qian Cai Acked-by: Michal Hocko Thanks! > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8ffe844766da..1559c1605072 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1703,12 +1703,12 @@ static int __ref __offline_pages(unsigned long start_pfn, > > failed_removal_isolated: > undo_isolate_page_range(start_pfn, end_pfn, MIGRATE_MOVABLE); > + memory_notify(MEM_CANCEL_OFFLINE, &arg); > failed_removal: > pr_debug("memory offlining [mem %#010llx-%#010llx] failed due to %s\n", > (unsigned long long) start_pfn << PAGE_SHIFT, > ((unsigned long long) end_pfn << PAGE_SHIFT) - 1, > reason); > - memory_notify(MEM_CANCEL_OFFLINE, &arg); > /* pushback to free area */ > mem_hotplug_done(); > return ret; > -- > 2.17.2 (Apple Git-113) -- Michal Hocko SUSE Labs