From: "Tobin C. Harding" <me@tobin.cc>
To: Christopher Lameter <cl@linux.com>
Cc: "Tobin C. Harding" <tobin@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>, Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] slob: Use slab_list instead of lru
Date: Thu, 14 Mar 2019 14:24:16 +1100 [thread overview]
Message-ID: <20190314032416.GA25492@eros.localdomain> (raw)
In-Reply-To: <0100016978719138-5260db28-77f5-4abb-8110-2732aa709c5e-000000@email.amazonses.com>
On Wed, Mar 13, 2019 at 07:05:02PM +0000, Christopher Lameter wrote:
> On Wed, 13 Mar 2019, Tobin C. Harding wrote:
>
> > @@ -297,7 +297,7 @@ static void *slob_alloc(size_t size, gfp_t gfp, int align, int node)
> > continue;
> >
> > /* Attempt to alloc */
> > - prev = sp->lru.prev;
> > + prev = sp->slab_list.prev;
> > b = slob_page_alloc(sp, size, align);
> > if (!b)
> > continue;
>
> Hmmm... Is there a way to use a macro or so to avoid referencing the field
> within the slab_list?
Thanks for the review. Next version includes a fix for this.
Tobin.
next prev parent reply other threads:[~2019-03-14 3:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 5:20 [PATCH v2 0/5]] mm: Use slab_list list_head " Tobin C. Harding
2019-03-13 5:20 ` [PATCH v2 1/5] slub: Add comments to endif pre-processor macros Tobin C. Harding
2019-03-13 19:00 ` Christopher Lameter
2019-03-13 5:20 ` [PATCH v2 2/5] slub: Use slab_list instead of lru Tobin C. Harding
2019-03-13 19:02 ` Christopher Lameter
2019-03-13 5:20 ` [PATCH v2 3/5] slab: " Tobin C. Harding
2019-03-13 5:20 ` [PATCH v2 4/5] slob: " Tobin C. Harding
2019-03-13 19:05 ` Christopher Lameter
2019-03-14 3:24 ` Tobin C. Harding [this message]
2019-03-13 5:20 ` [PATCH v2 5/5] mm: Remove stale comment from page struct Tobin C. Harding
2019-03-13 19:05 ` Christopher Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314032416.GA25492@eros.localdomain \
--to=me@tobin.cc \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tobin@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox