From: Peter Zijlstra <peterz@infradead.org>
To: Jan Stancek <jstancek@redhat.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
willy@infradead.org, riel@surriel.com, mhocko@suse.com,
ying.huang@intel.com, jrdr.linux@gmail.com, jglisse@redhat.com,
aneesh.kumar@linux.ibm.com, david@redhat.com,
aarcange@redhat.com, raquini@redhat.com, rientjes@google.com,
kirill@shutemov.name, mgorman@techsingularity.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/memory.c: do_fault: avoid usage of stale vm_area_struct
Date: Sat, 2 Mar 2019 19:45:44 +0100 [thread overview]
Message-ID: <20190302184544.GM14054@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <a5234d11b8cc158352a2f97fc33aa9ad90bb287b.1551550112.git.jstancek@redhat.com>
On Sat, Mar 02, 2019 at 07:19:39PM +0100, Jan Stancek wrote:
> static vm_fault_t do_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> + struct mm_struct *vm_mm = READ_ONCE(vma->vm_mm);
Would this not need a corresponding WRITE_ONCE() in vma_init() ?
next prev parent reply other threads:[~2019-03-02 18:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 15:11 [PATCH] " Jan Stancek
2019-03-02 17:10 ` Matthew Wilcox
2019-03-02 18:00 ` Jan Stancek
2019-03-02 18:19 ` [PATCH v2] " Jan Stancek
2019-03-02 18:45 ` Peter Zijlstra [this message]
2019-03-02 18:51 ` Andrea Arcangeli
2019-03-03 7:27 ` Jan Stancek
2019-03-03 7:28 ` [PATCH v3] " Jan Stancek
2019-03-03 10:36 ` Matthew Wilcox
2019-03-04 0:13 ` Rafael Aquini
2019-03-04 8:10 ` Minchan Kim
2019-03-04 8:19 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190302184544.GM14054@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=david@redhat.com \
--cc=jglisse@redhat.com \
--cc=jrdr.linux@gmail.com \
--cc=jstancek@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=raquini@redhat.com \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox