From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: zhong jiang <zhongjiang@huawei.com>
Cc: n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mhocko@suse.com, hughd@google.com, mhocko@kernel.org
Subject: Re: [PATCH] mm: hwpoison: fix thp split handing in soft_offline_in_use_page()
Date: Tue, 26 Feb 2019 16:51:56 +0300 [thread overview]
Message-ID: <20190226135156.mifspmbdyr6m3hff@kshutemo-mobl1> (raw)
In-Reply-To: <1551179880-65331-1-git-send-email-zhongjiang@huawei.com>
On Tue, Feb 26, 2019 at 07:18:00PM +0800, zhong jiang wrote:
> From: zhongjiang <zhongjiang@huawei.com>
>
> When soft_offline_in_use_page() runs on a thp tail page after pmd is plit,
s/plit/split/
> we trigger the following VM_BUG_ON_PAGE():
>
> Memory failure: 0x3755ff: non anonymous thp
> __get_any_page: 0x3755ff: unknown zero refcount page type 2fffff80000000
> Soft offlining pfn 0x34d805 at process virtual address 0x20fff000
> page:ffffea000d360140 count:0 mapcount:0 mapping:0000000000000000 index:0x1
> flags: 0x2fffff80000000()
> raw: 002fffff80000000 ffffea000d360108 ffffea000d360188 0000000000000000
> raw: 0000000000000001 0000000000000000 00000000ffffffff 0000000000000000
> page dumped because: VM_BUG_ON_PAGE(page_ref_count(page) == 0)
> ------------[ cut here ]------------
> kernel BUG at ./include/linux/mm.h:519!
>
> soft_offline_in_use_page() passed refcount and page lock from tail page to
> head page, which is not needed because we can pass any subpage to
> split_huge_page().
I don't see a description of what is going wrong and why change will fixed
it. From the description, it appears as it's cosmetic-only change.
Please elaborate.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2019-02-26 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 11:18 zhong jiang
2019-02-26 13:25 ` Michal Hocko
2019-02-26 13:51 ` Kirill A. Shutemov [this message]
2019-02-26 14:34 ` zhong jiang
2019-03-01 7:29 ` Naoya Horiguchi
2019-03-01 7:46 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226135156.mifspmbdyr6m3hff@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox