From: Andrew Morton <akpm@linux-foundation.org>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: daniel.m.jordan@oracle.com, mhocko@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] mm: Move recent_rotated pages calculation to shrink_inactive_list()
Date: Thu, 14 Feb 2019 12:57:59 -0800 [thread overview]
Message-ID: <20190214125759.97558dd947057db0397eb95e@linux-foundation.org> (raw)
In-Reply-To: <155014052145.28944.16497030123804725057.stgit@localhost.localdomain>
On Thu, 14 Feb 2019 13:35:21 +0300 Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
> Currently, struct reclaim_stat::nr_activate is a local variable,
> used only in shrink_page_list(). This patch introduces another
> local variable pgactivate to use instead of it, and reuses
> nr_activate to account number of active pages.
>
> Note, that we need nr_activate to be an array, since type of page
> may change during shrink_page_list() (see ClearPageSwapBacked()).
The patch has nothing to do with the Subject:
reclaim_stat::nr_activate is not a local variable - it is a struct member.
I can kinda see what the patch is doing but the changelog needs more
care, please.
next prev parent reply other threads:[~2019-02-14 20:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 10:35 [PATCH v2 0/4] mm: Generalize putback functions Kirill Tkhai
2019-02-14 10:35 ` [PATCH v2 1/4] mm: Move recent_rotated pages calculation to shrink_inactive_list() Kirill Tkhai
2019-02-14 20:57 ` Andrew Morton [this message]
2019-02-15 7:38 ` [PATCH v2.5 " Kirill Tkhai
2019-02-14 10:35 ` [PATCH v2 2/4] mm: Move nr_deactivate accounting to shrink_active_list() Kirill Tkhai
2019-02-14 10:35 ` [PATCH v2 3/4] mm: Remove pages_to_free argument of move_active_pages_to_lru() Kirill Tkhai
2019-02-14 10:35 ` [PATCH v2 4/4] mm: Generalize putback scan functions Kirill Tkhai
2019-02-15 20:39 ` Daniel Jordan
2019-02-15 22:01 ` Kirill Tkhai
2019-02-15 22:13 ` Daniel Jordan
2019-02-18 8:20 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214125759.97558dd947057db0397eb95e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox