linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, keith.busch@intel.com,
	keescook@chromium.org, dave.hansen@linux.intel.com,
	dan.j.williams@intel.com, linux-mm@kvack.org
Subject: Re: + mm-shuffle-default-enable-all-shuffling.patch added to -mm tree
Date: Tue, 12 Feb 2019 09:54:28 +0100	[thread overview]
Message-ID: <20190212085428.GP15609@dhcp22.suse.cz> (raw)
In-Reply-To: <20190206200254.bcdZQ%akpm@linux-foundation.org>

On Wed 06-02-19 12:02:54, Andrew Morton wrote:
> From: Dan Williams <dan.j.williams@intel.com>
> Subject: mm/shuffle: default enable all shuffling
> 
> Per Andrew's request arrange for all memory allocation shuffling code to
> be enabled by default.
> 
> The page_alloc.shuffle command line parameter can still be used to disable
> shuffling at boot, but the kernel will default enable the shuffling if the
> command line option is not specified.
> 
> Link: http://lkml.kernel.org/r/154943713572.3858443.11206307988382889377.stgit@dwillia2-desk3.amr.corp.intel.com
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Keith Busch <keith.busch@intel.com>
> 
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

I hope this is mmotm only thing and even then, is this really
something we want for linux-next? There are people doing testing and
potentially performance testing on that tree. Do we want to invalidate
all that work? I can see some argument about a testing coverage but do
we really need it for the change like this? The randomization is quite
simple to review and I assume Dan has given this good testing before
submition.
-- 
Michal Hocko
SUSE Labs


       reply	other threads:[~2019-02-12  8:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190206200254.bcdZQ%akpm@linux-foundation.org>
2019-02-12  8:54 ` Michal Hocko [this message]
2019-02-12 21:46   ` Andrew Morton
2019-02-14  8:33     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190212085428.GP15609@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=keescook@chromium.org \
    --cc=keith.busch@intel.com \
    --cc=linux-mm@kvack.org \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox