From: Peter Zijlstra <peterz@infradead.org>
To: Chintan Pandya <chintan.pandya@oneplus.com>
Cc: Linux Upstream <linux.upstream@oneplus.com>,
"hughd@google.com" <hughd@google.com>,
"jack@suse.cz" <jack@suse.cz>,
"mawilcox@microsoft.com" <mawilcox@microsoft.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RFC 1/2] page-flags: Make page lock operation atomic
Date: Mon, 11 Feb 2019 14:46:07 +0100 [thread overview]
Message-ID: <20190211134607.GA32511@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190211125337.16099-2-chintan.pandya@oneplus.com>
On Mon, Feb 11, 2019 at 12:53:53PM +0000, Chintan Pandya wrote:
> Currently, page lock operation is non-atomic. This is opening
> some scope for race condition. For ex, if 2 threads are accessing
> same page flags, it may happen that our desired thread's page
> lock bit (PG_locked) might get overwritten by other thread
> leaving page unlocked. This can cause issues later when some
> code expects page to be locked but it is not.
>
> Make page lock/unlock operation use the atomic version of
> set_bit API. There are other flag set operations which still
> uses non-atomic version of set_bit API. Bit, that might be
> the change for the future.
>
> Change-Id: I13bdbedc2b198af014d885e1925c93b83ed6660e
That doesn't belong in patches.
> Signed-off-by: Chintan Pandya <chintan.pandya@oneplus.com>
NAK.
This is bound to regress some stuff. Now agreed that using non-atomic
ops is tricky, but many are in places where we 'know' there can't be
concurrency.
If you can show any single one is wrong, we can fix that one, but we're
not going to blanket remove all this just because.
next prev parent reply other threads:[~2019-02-11 13:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 12:53 [RFC 0/2] Potential race condition with page lock Chintan Pandya
2019-02-11 12:53 ` [RFC 1/2] page-flags: Make page lock operation atomic Chintan Pandya
2019-02-11 13:46 ` Peter Zijlstra [this message]
2019-02-11 13:59 ` Linux Upstream
2019-02-11 17:48 ` Jan Kara
2019-02-11 17:56 ` Matthew Wilcox
2019-02-12 7:45 ` Jan Kara
2019-02-12 12:29 ` Peter Zijlstra
2019-02-11 12:53 ` [RFC 2/2] page-flags: Catch the double setter of page flags Chintan Pandya
2019-02-11 13:47 ` Peter Zijlstra
2019-02-11 14:01 ` Linux Upstream
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211134607.GA32511@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chintan.pandya@oneplus.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux.upstream@oneplus.com \
--cc=mawilcox@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox