From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA502C169C4 for ; Thu, 31 Jan 2019 08:52:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9433D2087F for ; Thu, 31 Jan 2019 08:52:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tobin.cc header.i=@tobin.cc header.b="YKYYufjE"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="OQYGaN8z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9433D2087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tobin.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22A338E0002; Thu, 31 Jan 2019 03:52:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B19C8E0001; Thu, 31 Jan 2019 03:52:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0546F8E0002; Thu, 31 Jan 2019 03:52:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by kanga.kvack.org (Postfix) with ESMTP id CB8548E0001 for ; Thu, 31 Jan 2019 03:52:07 -0500 (EST) Received: by mail-qt1-f199.google.com with SMTP id n95so2793818qte.16 for ; Thu, 31 Jan 2019 00:52:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:dkim-signature:date:from:to:cc :subject:message-id:references:mime-version:content-disposition :in-reply-to:user-agent; bh=fVvqtshcW3aQ/fCzF3Idj5wTT7LAWXWjPWnicnLXBQU=; b=m5spXg24aMv47FRkEknWIbWx1L7gflxTWu/xOgInBRZ1u7msF3LQBktxgf4hf2EPdE gc19gxabS1RQqe4hNsoNCk3ECoPfJRIevDSoS/Rz58cyCMz0KQkNrNZcjgKKXcVLj/wo 8q8i3y0Bo0ejyqDE3+cQyHCrSH+C3CcWzEYrBrJ1PCbDanUA/yaXmskUHXE8dJLpw0DW dFkr02GUUWvYL6u49WzWKikoxzLbkHwc9yVC/ydUjwJFQKNEMtw8/9VB6TvlKpBi+pjs BYnahMoLbWT4k8IqcrQtsHQ169wLuAz/2eYl8o0WG/p7O2eE2ryhw+k55Tefxwo3U8/T XRyg== X-Gm-Message-State: AJcUuke1xkeKVH1TePaXFeGOyl+lM/4kVypK9EHJ4kknx1nsoda0+cRA xsMR+K0R6QmlSMRQIB0TeO13pmfil1lB1JPXTUvr0cSJsZYaQAbKpjTV5Y4269ND60ZIJNbpoOJ KjqZiKvomqudXwbENMxzU7MH4SoZaZuOYhXaRsrXiE9ATuhxiY7NqFBr+jivjZWNS0A== X-Received: by 2002:ae9:dc47:: with SMTP id q68mr31420635qkf.111.1548924727546; Thu, 31 Jan 2019 00:52:07 -0800 (PST) X-Google-Smtp-Source: ALg8bN4qpjLEFmi89uTygVZjftBBF4Urgn/kyEl30Fq06sNsgcBEILttSVCBxRo/80nSukkKaNue X-Received: by 2002:ae9:dc47:: with SMTP id q68mr31420613qkf.111.1548924727028; Thu, 31 Jan 2019 00:52:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548924727; cv=none; d=google.com; s=arc-20160816; b=vhcuNBA7ZOQImkIkvdxFySOdhGdmahIo1aFc+AVR8FM7fNXAQEuQ71KWOdxfetKOQ5 FzfJuKPlmaDBErb/gdhhlh3UpiQ8O9KgSMMbBNNS6FqP0VvWREpQVNWLFtHtBIqgCeeg ofk41hjJ1bc/pzrY5X//nR5YV11XuoXK8xXc4Do00U3pHR9Q9kSF+zZCwad9jnO86W++ DhTv6T5lUccMQlAKVv2E0MxlHf2TnpjhlLevNkYCGbZw5U+hIFkLdVDzLT+UWCblCZW1 mW9QoKfrdu2GVzX5dVe7ADkv5dWRlBKAuhf7ijry8OgolQ+zqjVucfg2CEwNyDTqNOIy tIIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature:dkim-signature; bh=fVvqtshcW3aQ/fCzF3Idj5wTT7LAWXWjPWnicnLXBQU=; b=xfizEIVVbNSFmJPRFzSd2ItNP2Zoq9ASUpvBtANgRYqqmV1iK7qD4W+3nF8oZ+onOl iFOUS3kBlUlXN61sZ0RXhu/dp/Dbqod3+9cokP0r8GaVYDifAFUeNVJj/aUiHREmL2al ru9x2+Bml7dBv2QW60SUOd7G9AHAGupwTgqsvTFglNrU53k+4qcnoxrW21RLbaPbs5M9 7d4TCQShYx9B0mmUhLCi0kzGg7yunz/y6m21mVeinWLmOfgNXV1+X0CeE15MbpsBobi+ gt1PEBuQ8a2ULRw0nPGpLys8W0bZmC/lFTN89eSHt+bTYc8C29PzDCLiw30MW5P4wBUw jfQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm2 header.b=YKYYufjE; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=OQYGaN8z; spf=neutral (google.com: 64.147.123.25 is neither permitted nor denied by best guess record for domain of me@tobin.cc) smtp.mailfrom=me@tobin.cc Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com. [64.147.123.25]) by mx.google.com with ESMTPS id v126si2763547qka.234.2019.01.31.00.52.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 00:52:06 -0800 (PST) Received-SPF: neutral (google.com: 64.147.123.25 is neither permitted nor denied by best guess record for domain of me@tobin.cc) client-ip=64.147.123.25; Authentication-Results: mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm2 header.b=YKYYufjE; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=OQYGaN8z; spf=neutral (google.com: 64.147.123.25 is neither permitted nor denied by best guess record for domain of me@tobin.cc) smtp.mailfrom=me@tobin.cc Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 1DEF72010; Thu, 31 Jan 2019 03:52:05 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 31 Jan 2019 03:52:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobin.cc; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=fVvqtshcW3aQ/fCzF3Idj5wTT7L AWXWjPWnicnLXBQU=; b=YKYYufjEdGtvRUN8vPDv4LMSdt0+Xym/egEtYMCpiLB V5+fkvE26N+Pofy2akjpvYZxa7WUUTcPpZd7SMiDx+QVgEHVq36qfKwhQRnsToew YQJFI0SR7caVBqulssTpnseQxQIJnpUAx2gtf/18/Us3OygXJaPSyWZk/iQtcdr0 gIAgHph10pubckWQysDfJOHXNr+s6q52j7a1penC/xABGHSt83MP50aIQTYAjLTT Wues5zYYBq/RYigODJvdA9LOsafKUyHIxvar+ioHjHO575Aex1y9Xj4a97dKFEf6 yro4R04OHwmVXFyDtIhD+uGPOAFTktmFz+kd5oR3Hlw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fVvqts hcW3aQ/fCzF3Idj5wTT7LAWXWjPWnicnLXBQU=; b=OQYGaN8zVA74Ld/UTcwIJI WP3knQxhG+KbEmjVJ3plFO8GBE39iu+dfo9ArI3ECPtU/SUUXQuIG46e62Tn7Olz Ff0wVNjwj+0qgfbHCFl6VXnaTCcs5VHNSVDqi4GcbB+xGelhakWl9mPJtlIoKSEH MUaEERXQADdne7PnB+zOrmPgiHF8OXnTjdZWQaJXNUNQAEdlISZnG4KEkSp64Cot /FjQcvEAWc+wcATPoO3TiRD8FBDNuFLLTC7mCbjokSZRe4jxjP/VsA4lQ+Zk6dJD cRHPYqEY4woPNXSMIp9wabPoHJE7LFL/lGYcsKCf9bZUdiyRGjjt1hLCFQUDDqwQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjeehgdduvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftd dmnecujfgurhepfffhvffukfhfgggtuggjofgfsehttdertdforedvnecuhfhrohhmpedf vfhosghinhcuvedrucfjrghrughinhhgfdcuoehmvgesthhosghinhdrtggtqeenucfkph epuddukedrvdduuddrvddufedruddvvdenucfrrghrrghmpehmrghilhhfrhhomhepmhgv sehtohgsihhnrdgttgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (ppp118-211-213-122.bras1.syd2.internode.on.net [118.211.213.122]) by mail.messagingengine.com (Postfix) with ESMTPA id 63A9FE412C; Thu, 31 Jan 2019 03:52:01 -0500 (EST) Date: Thu, 31 Jan 2019 19:51:53 +1100 From: "Tobin C. Harding" To: William Kucharski Cc: Christopher Lameter , "Tobin C. Harding" , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] slub: Fix comment spelling mistake Message-ID: <20190131085153.GB23538@eros.localdomain> References: <20190131041003.15772-1-me@tobin.cc> <20190131041003.15772-2-me@tobin.cc> <9C8C1658-0418-41A9-9A74-477DB83EB6EF@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9C8C1658-0418-41A9-9A74-477DB83EB6EF@oracle.com> X-Mailer: Mutt 1.11.2 (2019-01-07) User-Agent: Mutt/1.11.2 (2019-01-07) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 31, 2019 at 01:10:21AM -0700, William Kucharski wrote: > > > > On Jan 30, 2019, at 9:10 PM, Tobin C. Harding wrote: > > > > Signed-off-by: Tobin C. Harding > > --- > > include/linux/slub_def.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h > > index 3a1a1dbc6f49..201a635be846 100644 > > --- a/include/linux/slub_def.h > > +++ b/include/linux/slub_def.h > > @@ -81,7 +81,7 @@ struct kmem_cache_order_objects { > > */ > > struct kmem_cache { > > struct kmem_cache_cpu __percpu *cpu_slab; > > - /* Used for retriving partial slabs etc */ > > + /* Used for retrieving partial slabs etc */ > > slab_flags_t flags; > > unsigned long min_partial; > > unsigned int size; /* The size of an object including meta data */ > > -- > > If you're going to do this cleanup, make the comment in line 84 grammatical: > > /* Used for retrieving partial slabs, etc. */ Nice grammar, I didn't know to put a comma there. Will fix and re-spin. > Then change lines 87 and 88 to remove the space between "meta" and "data" as the > word is "metadata" (as can be seen at line 102) and remove the period at the end > of the comment on line 89 ("Free pointer offset.") > > You might also want to change lines 125-127 to be a single line comment: > > /* Defragmentation by allocating from a remote node */ > > so the commenting style is consistent throughout. Will do with pleasure, thanks for the tips (and the review). thanks, Tobin.