From: Andrew Morton <akpm@linux-foundation.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Jiufei Xue <jiufei.xue@linux.alibaba.com>,
linux-mm@kvack.org, joseph.qi@linux.alibaba.com
Subject: Re: [PATCH] mm: fix sleeping function warning in alloc_swap_info
Date: Tue, 29 Jan 2019 11:13:46 -0800 [thread overview]
Message-ID: <20190129111346.fbb11cc79c09b7809f447bef@linux-foundation.org> (raw)
In-Reply-To: <132b9310-2478-19e1-aed3-48a2b448ca50@I-love.SAKURA.ne.jp>
On Tue, 29 Jan 2019 20:43:20 +0900 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> On 2019/01/29 16:21, Jiufei Xue wrote:
> > Trinity reports BUG:
> >
> > sleeping function called from invalid context at mm/vmalloc.c:1477
> > in_atomic(): 1, irqs_disabled(): 0, pid: 12269, name: trinity-c1
> >
> > [ 2748.573460] Call Trace:
> > [ 2748.575935] dump_stack+0x91/0xeb
> > [ 2748.578512] ___might_sleep+0x21c/0x250
> > [ 2748.581090] remove_vm_area+0x1d/0x90
> > [ 2748.583637] __vunmap+0x76/0x100
> > [ 2748.586120] __se_sys_swapon+0xb9a/0x1220
> > [ 2748.598973] do_syscall_64+0x60/0x210
> > [ 2748.601439] entry_SYSCALL_64_after_hwframe+0x49/0xbe
> >
> > This is triggered by calling kvfree() inside spinlock() section in
> > function alloc_swap_info().
> > Fix this by moving the kvfree() after spin_unlock().
> >
>
> Excuse me? But isn't kvfree() safe to be called with spinlock held?
Yes, I'm having trouble spotting where kvfree() can sleep. Perhaps it
*used* to sleep on mutex_lock(vmap_purge_lock), but
try_purge_vmap_area_lazy() is using mutex_trylock(). Confused.
kvfree() darn well *shouldn't* sleep!
next prev parent reply other threads:[~2019-01-29 19:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 7:21 Jiufei Xue
2019-01-29 8:53 ` Aaron Lu
2019-01-29 10:43 ` Joseph Qi
2019-01-29 11:19 ` Aaron Lu
2019-01-29 11:43 ` Tetsuo Handa
2019-01-29 19:13 ` Andrew Morton [this message]
2019-01-29 21:12 ` Tetsuo Handa
2019-01-29 21:51 ` Yang Shi
2019-01-30 0:42 ` Tetsuo Handa
2019-01-30 1:01 ` Andrew Morton
2019-01-30 1:11 ` Linus Torvalds
2019-01-30 1:23 ` Linus Torvalds
2019-01-30 2:54 ` Tetsuo Handa
2019-01-30 17:18 ` Linus Torvalds
2019-01-30 22:13 ` Andrew Morton
2019-03-07 14:43 ` Aaron Lu
2019-03-07 14:47 ` Andrey Ryabinin
2019-03-07 15:24 ` Aaron Lu
2019-03-07 16:33 ` Andrey Ryabinin
2019-03-08 2:41 ` Aaron Lu
2019-03-11 1:43 ` Jiufei Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129111346.fbb11cc79c09b7809f447bef@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jiufei.xue@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox