From: Michal Hocko <mhocko@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org,
Dave Hansen <dave.hansen@linux.intel.com>,
keith.busch@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, mgorman@suse.de
Subject: Re: [PATCH v7 2/3] mm: Move buddy list manipulations into helpers
Date: Fri, 25 Jan 2019 15:30:44 +0100 [thread overview]
Message-ID: <20190125143044.GO3560@dhcp22.suse.cz> (raw)
In-Reply-To: <154690327612.676627.7469591833063917773.stgit@dwillia2-desk3.amr.corp.intel.com>
On Mon 07-01-19 15:21:16, Dan Williams wrote:
> In preparation for runtime randomization of the zone lists, take all
> (well, most of) the list_*() functions in the buddy allocator and put
> them in helper functions. Provide a common control point for injecting
> additional behavior when freeing pages.
Looks good in general and it actually makes the code more readable.
One nit below
[...]
> +static inline void rmv_page_order(struct page *page)
> +{
> + __ClearPageBuddy(page);
> + set_page_private(page, 0);
> +}
> +
I guess we do not really need this helper and simply squash it to its
only user.
Acked-by: Michal Hocko <mhocko@suse.com>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-01-25 14:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 23:21 [PATCH v7 0/3] mm: Randomize free memory Dan Williams
2019-01-07 23:21 ` Dan Williams
2019-01-07 23:21 ` [PATCH v7 1/3] mm: Shuffle initial free memory to improve memory-side-cache utilization Dan Williams
2019-01-07 23:21 ` Dan Williams
2019-01-08 0:18 ` Kees Cook
2019-01-08 0:18 ` Kees Cook
2019-01-08 1:48 ` Dan Williams
2019-01-08 1:48 ` Dan Williams
2019-01-08 23:24 ` Kees Cook
2019-01-08 23:24 ` Kees Cook
2019-01-10 10:56 ` Mel Gorman
2019-01-10 21:29 ` Dan Williams
2019-01-10 21:29 ` Dan Williams
2019-01-10 22:52 ` Kees Cook
2019-01-10 22:52 ` Kees Cook
2019-01-25 14:20 ` Michal Hocko
2019-01-29 19:26 ` Dan Williams
2019-01-29 20:04 ` Dan Williams
2019-01-07 23:21 ` [PATCH v7 2/3] mm: Move buddy list manipulations into helpers Dan Williams
2019-01-07 23:21 ` Dan Williams
2019-01-25 14:30 ` Michal Hocko [this message]
2019-01-29 19:27 ` Dan Williams
2019-01-07 23:21 ` [PATCH v7 3/3] mm: Maintain randomization of page free lists Dan Williams
2019-01-07 23:21 ` Dan Williams
2019-01-08 0:19 ` Kees Cook
2019-01-08 0:19 ` Kees Cook
2019-01-25 14:32 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125143044.GO3560@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox