From: Chris Down <chris@chrisdown.name>
To: Roman Gushchin <guro@fb.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>, Tejun Heo <tj@kernel.org>,
Dennis Zhou <dennis@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH 1/2] mm: Rename ambiguously named memory.stat counters and functions
Date: Wed, 23 Jan 2019 20:06:38 -0500 [thread overview]
Message-ID: <20190124010638.GB9055@chrisdown.name> (raw)
In-Reply-To: <20190123235940.GA21563@castle.DHCP.thefacebook.com>
Roman Gushchin writes:
>I'd personally go with memcg_vmstat_percpu. Not insisting,
>but you end up using both vmstat and vmstats, which isn't very
>consistent.
Yeah, we also have similar naming in accumulated_vmstats. Hmm, let me think
about this a bit and get back to you tomorrow. The main bit I was concerned
about was memory_events vs. events -- I don't really have strong opinions on
the percpu struct's exact naming/plurality.
>Other than that looks good to me. Please, feel free to add
>Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
prev parent reply other threads:[~2019-01-24 1:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 22:30 Chris Down
2019-01-23 23:59 ` Roman Gushchin
2019-01-24 1:06 ` Chris Down [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124010638.GB9055@chrisdown.name \
--to=chris@chrisdown.name \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dennis@kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox