From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by kanga.kvack.org (Postfix) with ESMTP id 423AF8E0001 for ; Wed, 23 Jan 2019 05:18:45 -0500 (EST) Received: by mail-ed1-f72.google.com with SMTP id e17so741740edr.7 for ; Wed, 23 Jan 2019 02:18:45 -0800 (PST) Received: from suse.de (nat.nue.novell.com. [2620:113:80c0:5::2222]) by mx.google.com with ESMTP id b12si5332793edw.390.2019.01.23.02.18.43 for ; Wed, 23 Jan 2019 02:18:43 -0800 (PST) Date: Wed, 23 Jan 2019 11:18:42 +0100 From: Oscar Salvador Subject: Re: [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages Message-ID: <20190123101838.qxsapn4dhcergs6t@d104.suse.de> References: <20190122154407.18417-1-osalvador@suse.de> <20190123094717.GQ4087@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190123094717.GQ4087@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com On Wed, Jan 23, 2019 at 10:47:17AM +0100, Michal Hocko wrote: > So this should be probably folded into the above patch as it is > incomplete unless I am missing something. Well, they are triggered from different paths. The former error was triggered in: removable_show is_mem_section_removable is_pageblock_removable_nolock has_unmovable_pages while this one is triggered when actually doing the offline operation __offline_pages scan_movable_pages But I do agree that one without the other is not really useful, an incomplete. The truth is that I did not spot this one when fixing [1] because I did not really try to offline the memblock back then, so my fault. While I agree that the best approach would be to fold this one into [1], I am not sure if it is too late for that as it seems that [1] was already released into mainline, and moreover to stable. I guess I will have Andrew decide what is the best way to carry on here. [1] https://patchwork.kernel.org/patch/10739963/ > > > Signed-off-by: Oscar Salvador > > Other than that the change looks good to me. > > Acked-by: Michal Hocko Thanks! -- Oscar Salvador SUSE L3