From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by kanga.kvack.org (Postfix) with ESMTP id 3B5CD8E0025 for ; Mon, 21 Jan 2019 03:38:12 -0500 (EST) Received: by mail-wm1-f70.google.com with SMTP id y85so2491458wmc.7 for ; Mon, 21 Jan 2019 00:38:12 -0800 (PST) Received: from newverein.lst.de (verein.lst.de. [213.95.11.211]) by mx.google.com with ESMTPS id s82si31585454wmf.82.2019.01.21.00.38.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 00:38:10 -0800 (PST) Date: Mon, 21 Jan 2019 09:38:10 +0100 From: Christoph Hellwig Subject: Re: [PATCH V14 00/18] block: support multi-page bvec Message-ID: <20190121083810.GA18648@lst.de> References: <20190121081805.32727-1-ming.lei@redhat.com> <20190121082246.GA18305@lst.de> <20190121083711.GA29495@ming.t460p> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190121083711.GA29495@ming.t460p> Sender: owner-linux-mm@kvack.org List-ID: To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com On Mon, Jan 21, 2019 at 04:37:12PM +0800, Ming Lei wrote: > On Mon, Jan 21, 2019 at 09:22:46AM +0100, Christoph Hellwig wrote: > > On Mon, Jan 21, 2019 at 04:17:47PM +0800, Ming Lei wrote: > > > V14: > > > - drop patch(patch 4 in V13) for renaming bvec helpers, as suggested by Jens > > > - use mp_bvec_* as multi-page bvec helper name > > > > WTF? Where is this coming from? mp is just a nightmare of a name, > > and I also didn't see any comments like that. > > You should see the recent discussion in which Jens doesn't agree on > renaming bvec helper name, so the previous patch of 'block: rename bvec helpers' Where is that discussion?