From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Shakeel Butt <shakeelb@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Shakeel Butt <shakeelb@google.com>
Subject: Re: [PATCH] mm, oom: remove 'prefer children over parent' heuristic
Date: Mon, 21 Jan 2019 10:23:21 +0900 [thread overview]
Message-ID: <201901210123.x0L1NLFJ043029@www262.sakura.ne.jp> (raw)
Message-ID: <20190121012321.Z9ubwM_oE3B_hfcfxY7qk50wmDCRnjfMvoodxwrr91I@z> (raw)
In-Reply-To: <20190120215059.183552-1-shakeelb@google.com>
Shakeel Butt wrote:
> + pr_err("%s: Kill process %d (%s) score %lu or sacrifice child\n",
> + message, task_pid_nr(p), p->comm, oc->chosen_points);
This patch is to make "or sacrifice child" false. And, the process reported
by this line will become always same with the process reported by
pr_err("Killed process %d (%s) total-vm:%lukB, anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB\n",
task_pid_nr(victim), victim->comm, K(victim->mm->total_vm),
K(get_mm_counter(victim->mm, MM_ANONPAGES)),
K(get_mm_counter(victim->mm, MM_FILEPAGES)),
K(get_mm_counter(victim->mm, MM_SHMEMPAGES)));
. Then, better to merge these pr_err() lines?
next prev parent reply other threads:[~2019-01-21 1:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 21:50 Shakeel Butt
2019-01-20 21:50 ` Shakeel Butt
2019-01-21 1:23 ` Tetsuo Handa [this message]
2019-01-21 1:23 ` Tetsuo Handa
2019-01-21 18:15 ` Shakeel Butt
2019-01-21 18:15 ` Shakeel Butt
2019-01-21 9:19 ` Michal Hocko
2019-01-21 18:16 ` Shakeel Butt
2019-01-21 18:16 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201901210123.x0L1NLFJ043029@www262.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox