From: Mike Rapoport <rppt@linux.ibm.com>
To: Yang Fan <nullptr.cpp@gmail.com>
Cc: akpm@linux-foundation.org, will.deacon@arm.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] mm/mmap.c: Remove some redundancy in arch_get_unmapped_area_topdown()
Date: Sun, 20 Jan 2019 19:09:20 +0200 [thread overview]
Message-ID: <20190120170919.GB28141@rapoport-lnx> (raw)
In-Reply-To: <cover.1547966629.git.nullptr.cpp@gmail.com>
Hi,
On Sun, Jan 20, 2019 at 09:12:26AM +0100, Yang Fan wrote:
> This patchset remove some redundancy in function
> arch_get_unmapped_area_topdown().
>
> [PATCH 1/2] mm/mmap.c: Remove redundant variable 'addr' in
> arch_get_unmapped_area_topdown()
> [PATCH 2/2] mm/mmap.c: Remove redundant const qualifier of the no-pointer
> parameters
>
> Yang Fan (2):
> mm/mmap.c: Remove redundant variable 'addr' in
> arch_get_unmapped_area_topdown()
> mm/mmap.c: Remove redundant const qualifier of the no-pointer
> parameters
I think it would be better to merge these patches into one.
For the merged patch feel free to add
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> mm/mmap.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> --
> 2.17.1
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2019-01-20 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 8:12 Yang Fan
2019-01-20 8:13 ` [PATCH 1/2] mm/mmap.c: Remove redundant variable 'addr' " Yang Fan
2019-01-23 14:09 ` William Kucharski
2019-01-20 8:13 ` [PATCH 2/2] mm/mmap.c: Remove redundant const qualifier of the no-pointer parameters Yang Fan
2019-01-20 17:09 ` Mike Rapoport [this message]
2019-01-27 4:11 ` [PATCH v2] mm/mmap.c: Remove some redundancy in arch_get_unmapped_area_topdown() Yang Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190120170919.GB28141@rapoport-lnx \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nullptr.cpp@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox